Bug 85897 - [Chromium] OS(ANDROID) ImageDiff requires us to build WTF for both host and target
Summary: [Chromium] OS(ANDROID) ImageDiff requires us to build WTF for both host and t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 85904
Blocks: 66687
  Show dependency treegraph
 
Reported: 2012-05-08 10:35 PDT by Adam Barth
Modified: 2012-05-08 20:36 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2012-05-08 10:36 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-05-08 10:35:30 PDT
[Chromium] OS(ANDROID) ImageDiff requires us to build WTF for both host and target
Comment 1 Adam Barth 2012-05-08 10:36:46 PDT
Created attachment 140739 [details]
Patch
Comment 2 Tony Chang 2012-05-08 10:48:27 PDT
Comment on attachment 140739 [details]
Patch

What is android_build_type?
Comment 3 Tony Chang 2012-05-08 11:05:47 PDT
Comment on attachment 140739 [details]
Patch

Peter explained to me what android_build_type is.  LGTM.
Comment 4 Peter Beverloo 2012-05-08 11:14:50 PDT
Confirmed this works fine, patch LGTM as well. Thanks Adam!
Comment 5 WebKit Review Bot 2012-05-08 11:44:30 PDT
Comment on attachment 140739 [details]
Patch

Clearing flags on attachment: 140739

Committed r116440: <http://trac.webkit.org/changeset/116440>
Comment 6 WebKit Review Bot 2012-05-08 11:44:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2012-05-08 12:08:27 PDT
Re-opened since this is blocked by 85904
Comment 8 Hao Zheng 2012-05-08 19:50:10 PDT
I remember I have removed the dependency on wtf of ImageDiff. Why we need it again?
Comment 9 Hao Zheng 2012-05-08 19:51:17 PDT
Oh, sorry. I didn't notice replying the bug would reopen it.
Comment 10 Adam Barth 2012-05-08 20:36:11 PDT
(In reply to comment #8)
> I remember I have removed the dependency on wtf of ImageDiff. Why we need it again?

Ah, that means we can fix this downstream.  Thanks!