Bug 85891 - WKContextSetCacheModel(contextref, kWKCacheModelDocumentViewer) doesn't prevent pages from going into the PageCache
Summary: WKContextSetCacheModel(contextref, kWKCacheModelDocumentViewer) doesn't preve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords:
Depends on: 85888
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-08 09:23 PDT by Jessie Berlin
Modified: 2012-05-15 12:05 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.28 KB, patch)
2012-05-15 10:02 PDT, Jessie Berlin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2012-05-08 09:23:54 PDT 
Instead, pages go into the page cache only to come out as soon as the first purge is done.

If m_capacity is 0, PageCache::canCache should return false immediately.

I have a fix, but I am blocked on https://bugs.webkit.org/show_bug.cgi?id=85888 for the ability to test it (since currently the WK2 API for determining when something goes into or out of the page cache is broken).
Comment 1 Jessie Berlin 2012-05-15 10:02:50 PDT 
Created attachment 141990 [details]
Patch
Comment 2 Jessie Berlin 2012-05-15 12:05:32 PDT 
Comment on attachment 141990 [details]
Patch

Committed in http://trac.webkit.org/changeset/117112