Bug 85868 – REGRESSION(r116395): css3/filters/custom/filter-repaint-custom-rotated.html fails on Chromium-Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Kent Tamura]

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=css3%2Ffilters%2Fcustom%2Ffilter-repaint-custom-rotated.html

Looks off-by-one. Does anyone have an idea waht's wrong?

[Eric Seidel (no email)]

http://trac.webkit.org/changeset/116395

[Kent Tamura]

I confirmed the size of the green box was not changed by r116395.  Just the repaint area was enlarged.

       if (localClipRect != PaintInfo::infiniteRect()) { 
+          if ((flags & IncludeSelfTransform) && layer->paintsWithTransform(PaintBehaviorNormal)) 
+              localClipRect = layer->transform()->mapRect(localClipRect); 

localClipRect was (0,0) 100x100 before the mapRect() call. After that, it becomes (-1,-1) 101x101.
In TransformationMatric::mapRect(), the variable 'resultQuad' is:
  (100, -1.42109e-14) (100, 100) (1.42109e-14, 100) (-1.42109e-14, 7.99361e-15)

It looks an ignorable error.

[Kent Tamura]

Oh, this issue has been resolved by ENABLE_SUBPIXEL_LAYOUT.  Awesome :-)

[Kent Tamura]

Removed the failure expectation by http://trac.webkit.org/changeset/117941.