Bug 85858 - Change the return type of Entry.toURL() back to String from KURL
Summary: Change the return type of Entry.toURL() back to String from KURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kinuko Yasuda
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-07 21:40 PDT by Kinuko Yasuda
Modified: 2012-05-10 02:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.90 KB, patch)
2012-05-07 21:44 PDT, Kinuko Yasuda 		no flags Details | Formatted Diff | Diff
Patch (5.90 KB, patch)
2012-05-07 21:55 PDT, Kinuko Yasuda 		no flags Details | Formatted Diff | Diff
Patch (2.60 KB, patch)
2012-05-07 23:51 PDT, Kinuko Yasuda 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2012-05-07 21:40:23 PDT 
Change the return type of Entry.toURL() back to String from KURL.
I once changed it from String to KURL in https://bugs.webkit.org/show_bug.cgi?id=85736 but it turned out that it needs implicit conversion and could incur an extra overhead.
Comment 1 Kinuko Yasuda 2012-05-07 21:44:11 PDT 
Created attachment 140668 [details]
Patch
Comment 2 Kinuko Yasuda 2012-05-07 21:55:16 PDT 
Created attachment 140669 [details]
Patch
Comment 3 WebKit Review Bot 2012-05-07 22:46:40 PDT 
Comment on attachment 140669 [details]
Patch

Attachment 140669 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12643550
Comment 4 Kinuko Yasuda 2012-05-07 23:51:12 PDT 
Created attachment 140682 [details]
Patch
Comment 5 Ryosuke Niwa 2012-05-10 01:03:37 PDT 
Comment on attachment 140682 [details]
Patch

rs=me.
Comment 6 WebKit Review Bot 2012-05-10 02:58:58 PDT 
Comment on attachment 140682 [details]
Patch

Clearing flags on attachment: 140682

Committed r116623: <http://trac.webkit.org/changeset/116623>
Comment 7 WebKit Review Bot 2012-05-10 02:59:04 PDT 
All reviewed patches have been landed.  Closing bug.