RESOLVED FIXED Bug 85855
Compositing layers with transformed children not large enough to show contents 
https://bugs.webkit.org/show_bug.cgi?id=85855
Summary Compositing layers with transformed children not large enough to show contents
Simon Fraser (smfr)
Reported 2012-05-07 20:51:33 PDT
http://trac.webkit.org/changeset/109851/ regressed (or revealed) a bug in some compositing content (test case attached). The size of the #slider layer is not big enough to contain the transformed children.
Attachments
Testcase (701 bytes, text/html)
2012-05-07 20:51 PDT, Simon Fraser (smfr) 		no flags
Details
Patch (6.11 KB, patch)
2012-05-07 22:33 PDT, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-05-07 20:51:52 PDT
Created attachment 140660 [details] Testcase
Simon Fraser (smfr)
Comment 2 2012-05-07 20:52:13 PDT
<rdar://problem/11401995>
Radar WebKit Bug Importer
Comment 3 2012-05-07 20:52:45 PDT
<rdar://problem/11402771>
Simon Fraser (smfr)
Comment 4 2012-05-07 21:08:13 PDT
RenderLayer::calculateLayerBounds() is using convertToLayerCoords() which ignores transforms!
Simon Fraser (smfr)
Comment 5 2012-05-07 22:11:15 PDT
Ah, the actual bug was caused by http://trac.webkit.org/changeset/114518, by the newly added UseLocalClipRectIfPossible code path in RenderLayer::calculateLayerBounds() which didn't handle transforms.
Simon Fraser (smfr)
Comment 6 2012-05-07 22:33:54 PDT
Created attachment 140675 [details] Patch
mitz
Comment 7 2012-05-07 22:36:29 PDT
Comment on attachment 140675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140675&action=review > Source/WebCore/rendering/RenderLayer.cpp:4163 > + TransformationMatrix* affineTrans = layer->transform(); Weird name for a local variable that’s not really needed.
Simon Fraser (smfr)
Comment 8 2012-05-07 22:46:04 PDT
http://trac.webkit.org/changeset/116395
Note You need to log in before you can comment on or make changes to this bug.