Bug 85846 – Remove more BUILDING_ON_LEOPARD usage in PLATFORM(MAC) code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Remove more BUILDING_LEOPARD usage in PLATFORM(MAC) code

[Eric Seidel (no email)]

Created attachment 140629 [details]
Patch

[Eric Seidel (no email)]

I originally tried to remove all of it at once, but the patch would have been huge. :)

[Mark Rowe (bdash)]

It'd be worth updating the bug title and ChangeLog entries to refer to the correct macro name.

[Eric Seidel (no email)]

Ah, sure.  Will do.

[Eric Seidel (no email)]

Created attachment 140634 [details]
Fix my typo

[Ryosuke Niwa]

The patch looks reasonable. Are people from Mac port okay with removing this flag?

[Eric Seidel (no email)]

To be clear, I'm not removing any flags.  I'm just removing support for building PLATFORM(MAC) on Leopard.  It's not been possible to build PLATFORM(MAC) on Leoaprd for a long time, this is just dead code.

The only bit to review here is to make sure that I did the removal correctly and didn't affect any other OS version. :)  I don't believe I did, but that's the only part to review.  The rest is just a rubber stamp.

Chromium has plans to drop Leopard support very soon.  Then removing Leopard support from WebKit will require even less thought. :)

[Adam Barth]

Comment on attachment 140634 [details]
Fix my typo

View in context: https://bugs.webkit.org/attachment.cgi?id=140634&action=review

> Source/WebCore/WebCore.exp.in:2119
>  __ZN7WebCore6Editor13lowercaseWordEv
>  __ZN7WebCore6Editor13uppercaseWordEv
>  __ZN7WebCore6Editor14capitalizeWordEv

Should these get alphabetized with the rest of the file?

[Eric Seidel (no email)]

Comment on attachment 140634 [details]
Fix my typo

View in context: https://bugs.webkit.org/attachment.cgi?id=140634&action=review

>> Source/WebCore/WebCore.exp.in:2119
>>  __ZN7WebCore6Editor14capitalizeWordEv
> 
> Should these get alphabetized with the rest of the file?

Presumably, but seems not worth it for this change.

[WebKit Review Bot]

Comment on attachment 140634 [details]
Fix my typo

Rejecting attachment 140634 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ource/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm
patching file Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm
patching file Source/WebCore/platform/graphics/ca/mac/TileCache.mm
Hunk #2 succeeded at 154 (offset 1 line).
Hunk #3 succeeded at 179 (offset 1 line).
Hunk #4 succeeded at 395 (offset 7 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12731489

[Eric Seidel (no email)]

Comment on attachment 140634 [details]
Fix my typo

I doubt this still applies... but just in case.  Leopard is dead now!

[WebKit Review Bot]

Comment on attachment 140634 [details]
Fix my typo

Rejecting attachment 140634 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ource/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm
patching file Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm
patching file Source/WebCore/platform/graphics/ca/mac/TileCache.mm
Hunk #2 succeeded at 154 (offset 1 line).
Hunk #3 succeeded at 179 (offset 1 line).
Hunk #4 succeeded at 395 (offset 7 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13120162

[Eric Seidel (no email)]

Created attachment 150086 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 150086 [details]
Patch for landing

Clearing flags on attachment: 150086

Committed r121524: <http://trac.webkit.org/changeset/121524>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.