Bug 85841 - IndexedDB: call abort handler when there are problems committing
Summary: IndexedDB: call abort handler when there are problems committing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-07 16:07 PDT by Alec Flett
Modified: 2012-05-09 15:08 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.39 KB, patch)
2012-05-08 12:07 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Patch (4.60 KB, patch)
2012-05-09 13:45 PDT, Alec Flett
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2012-05-07 16:07:28 PDT
IndexedDB: call abort handler when there are problems committing
Comment 1 Alec Flett 2012-05-08 12:07:32 PDT
Created attachment 140759 [details]
Patch
Comment 2 David Grogan 2012-05-09 13:41:33 PDT
LGTM
Comment 3 David Grogan 2012-05-09 13:44:02 PDT
Comment on attachment 140759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140759&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

You'll have to remove the OOPS and re-upload.  The reasoning from my similar patch applies here (https://bugs.webkit.org/attachment.cgi?id=140156&action=review)

No new tests.  We think the only way this will happen is if the leveldb store gets corrupted, either due to IO problems or coding error.  We're working on a pyauto test that corrups the db in the background but can't do that from DRT.
Comment 4 Alec Flett 2012-05-09 13:45:00 PDT
Created attachment 141009 [details]
Patch
Comment 5 Alec Flett 2012-05-09 13:46:23 PDT
ojan - r? No tests here, as explained in the changelog - this is going to help us reproduce a problem we're seeing in the wild, but this is quite safe otherwise. (and all our existing tests already basically call commit())
Comment 6 Alec Flett 2012-05-09 14:50:27 PDT
Comment on attachment 141009 [details]
Patch

oops, forgot the cq? - jsbell@
Comment 7 Alec Flett 2012-05-09 14:50:46 PDT
er rather, dgrogan@ - cq?
Comment 8 WebKit Review Bot 2012-05-09 15:08:26 PDT
Comment on attachment 141009 [details]
Patch

Clearing flags on attachment: 141009

Committed r116562: <http://trac.webkit.org/changeset/116562>
Comment 9 WebKit Review Bot 2012-05-09 15:08:31 PDT
All reviewed patches have been landed.  Closing bug.