Bug 85839 – [Qt] Unbreak debugging of WebKit2.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Alexis Menard (darktears)]

[Qt] Unbreak debugging of WebKit2.

[Alexis Menard (darktears)]

Created attachment 140614 [details]
Patch

[Simon Hausmann]

Comment on attachment 140614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140614&action=review

> Tools/WebKitTestRunner/qt/main.cpp:71
> +void sigcontHandler(int signal)

missing static

> Tools/WebKitTestRunner/qt/main.cpp:90
> +        signal(SIGCONT, sigcontHandler);

sigaction should be used instead of signal.

[Simon Hausmann]

Comment on attachment 140614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140614&action=review

>> Tools/WebKitTestRunner/qt/main.cpp:71
>> +void sigcontHandler(int signal)
> 
> missing static

I forgot: unused parameter signal :)

[Kenneth Rohde Christiansen]

(In reply to comment #3)
> (From update of attachment 140614 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140614&action=review
> 
> >> Tools/WebKitTestRunner/qt/main.cpp:71
> >> +void sigcontHandler(int signal)
> > 
> > missing static
> 
> I forgot: unused parameter signal :)

Wow, you are up late Simon :-) I guess we should be sleeping.

[Kenneth Rohde Christiansen]

Comment on attachment 140614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140614&action=review

Looks pretty ok

> Source/WebKit2/ChangeLog:8
> +        When you attach GDB to a running process it stops it.

I would add a , before 'it'

> Source/WebKit2/ChangeLog:14
> +        state when the debugger send the signal SIGCONT. The old code

sent*

[Alexis Menard (darktears)]

Created attachment 140619 [details]
Patch

[Alexis Menard (darktears)]

I'm very unfamiliar with the sigaction stuff so I hope I did right.

[Simon Hausmann]

Comment on attachment 140619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140619&action=review

> Source/WebKit2/qt/MainQt.cpp:68
> +        sigaction(SIGCONT, 0, &oldAction);
> +        sigaction(SIGCONT, &newAction, 0);

I think you should combine these into one call, i.e.

    sigaction(SIGCONT, &newAction, &oldAction);

[Alexis Menard (darktears)]

Committed r116417: <http://trac.webkit.org/changeset/116417>