Bug 85812 - [BlackBerry] Delete previous buffer when new over-scroll image path is set
Summary: [BlackBerry] Delete previous buffer when new over-scroll image path is set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-07 11:22 PDT by Andrew Lo
Modified: 2012-05-07 13:37 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2012-05-07 11:36 PDT, Andrew Lo 		no flags Details | Formatted Diff | Diff
Patch (1.91 KB, patch)
2012-05-07 12:28 PDT, Andrew Lo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Lo 2012-05-07 11:22:36 PDT 
When a new file path for over-scroll image path is set, the old buffer is not deleted before creating a new one.
Comment 1 Andrew Lo 2012-05-07 11:36:37 PDT 
Created attachment 140564 [details]
Patch
Comment 2 Rob Buis 2012-05-07 12:22:32 PDT 
Comment on attachment 140564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140564&action=review

Looks good, but please fix the period.

> Source/WebKit/blackberry/Api/BackingStore.cpp:1221
> +    // For now we fallback to solid color if sizes don't match, later we can implement tiling

It is preferred to end these sentences with a period.
Comment 3 Andrew Lo 2012-05-07 12:28:25 PDT 
Created attachment 140571 [details]
Patch
Comment 4 Rob Buis 2012-05-07 12:36:57 PDT 
Comment on attachment 140571 [details]
Patch

Looks good.
Comment 5 WebKit Review Bot 2012-05-07 13:37:02 PDT 
Comment on attachment 140571 [details]
Patch

Clearing flags on attachment: 140571

Committed r116350: <http://trac.webkit.org/changeset/116350>
Comment 6 WebKit Review Bot 2012-05-07 13:37:07 PDT 
All reviewed patches have been landed.  Closing bug.