WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
85812
[BlackBerry] Delete previous buffer when new over-scroll image path is set
https://bugs.webkit.org/show_bug.cgi?id=85812
Summary
[BlackBerry] Delete previous buffer when new over-scroll image path is set
Andrew Lo
Reported
2012-05-07 11:22:36 PDT
When a new file path for over-scroll image path is set, the old buffer is not deleted before creating a new one.
Attachments
Patch
(1.82 KB, patch)
2012-05-07 11:36 PDT
,
Andrew Lo
no flags
Details
Formatted Diff
Diff
Patch
(1.91 KB, patch)
2012-05-07 12:28 PDT
,
Andrew Lo
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andrew Lo
Comment 1
2012-05-07 11:36:37 PDT
Created
attachment 140564
[details]
Patch
Rob Buis
Comment 2
2012-05-07 12:22:32 PDT
Comment on
attachment 140564
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=140564&action=review
Looks good, but please fix the period.
> Source/WebKit/blackberry/Api/BackingStore.cpp:1221 > + // For now we fallback to solid color if sizes don't match, later we can implement tiling
It is preferred to end these sentences with a period.
Andrew Lo
Comment 3
2012-05-07 12:28:25 PDT
Created
attachment 140571
[details]
Patch
Rob Buis
Comment 4
2012-05-07 12:36:57 PDT
Comment on
attachment 140571
[details]
Patch Looks good.
WebKit Review Bot
Comment 5
2012-05-07 13:37:02 PDT
Comment on
attachment 140571
[details]
Patch Clearing flags on attachment: 140571 Committed
r116350
: <
http://trac.webkit.org/changeset/116350
>
WebKit Review Bot
Comment 6
2012-05-07 13:37:07 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug