Bug 85805 – Shrink SVGInlineTextBox object size

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Rob Buis]

The way we use bitpacking here is not ideal.

[Rob Buis]

Created attachment 140541 [details]
Patch

[Darin Adler]

Comment on attachment 140541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140541&action=review

Where’s the compile-time size assertion for this class?

> Source/WebCore/rendering/svg/SVGInlineTextBox.h:86
> +    unsigned m_paintingResourceMode : 4;

When we add a new mode, what will point someone here to add more bits? I am worried that this mode is defined in another file, and someone modifying it would have no reason to look here. Maybe a comment in the file that defines the enum?

[Rob Buis]

(In reply to comment #2)
> (From update of attachment 140541 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140541&action=review
> 
> Where’s the compile-time size assertion for this class?
> 
> > Source/WebCore/rendering/svg/SVGInlineTextBox.h:86
> > +    unsigned m_paintingResourceMode : 4;
> 
> When we add a new mode, what will point someone here to add more bits? I am worried that this mode is defined in another file, and someone modifying it would have no reason to look here. Maybe a comment in the file that defines the enum?

I fixed both before landing it in r116343.
Cheers,

Rob.