Bug 85802 – Web Inspector: Hangup when continuously changing a css width value in Inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

Reported against Chromium:

URL : http://einstufungstest.dw.de/index.php?id=4 

1. Go to http://einstufungstest.dw.de/index.php?id=4 
2. Right Mouse click on the Webpage and go to the Element Properties 
3. Click on the div element "tx_dwlanguagetest_content"
4. Go to Matches CSS Rules and Change the value "width" of the css class "tx_dwlanguagetest_content" with double click on it and press up or down keys 
5. Google Crome Render Prozess getting Crazy and take all the cpu time 

Upstreaming http://code.google.com/p/chromium/issues/detail?id=113620

[Alexander Pavlov (apavlov)]

Created attachment 140524 [details]
Patch

[WebKit Review Bot]

Comment on attachment 140524 [details]
Patch

Attachment 140524 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12644173

New failing tests:
inspector/styles/styles-new-API.html

[WebKit Review Bot]

Created attachment 140527 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Alexander Pavlov (apavlov)]

(In reply to comment #2)
> (From update of attachment 140524 [details])
> Attachment 140524 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12644173
> 
> New failing tests:
> inspector/styles/styles-new-API.html

Seems to be a glitch testing against the red tree, since it passes locally, and this test is not present in the attached test results.

[Pavel Feldman]

Comment on attachment 140524 [details]
Patch

This way we get out of memory. Could you instead address the performance bug via optimizing the style editing code?

[Alexander Pavlov (apavlov)]

Created attachment 144091 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 144091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144091&action=review

> Source/WebCore/inspector/InspectorStyleSheet.cpp:661
> +                prefix.resize(0);

Please use clear() instead.

> Source/WebCore/inspector/InspectorStyleSheet.cpp:666
> +                prefix.resize(0);

Ditto.

[Alexander Pavlov (apavlov)]

Committed r118538: <http://trac.webkit.org/changeset/118538>