Bug 85799 - IconDatabase: Move icon retain/release off of the main thread.
Summary: IconDatabase: Move icon retain/release off of the main thread.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Keywords: InRadar
Depends on: 86854
  Show dependency treegraph
Reported: 2012-05-07 06:40 PDT by Andreas Kling
Modified: 2012-05-18 07:24 PDT (History)
4 users (show)

See Also:

Patch (12.82 KB, patch)
2012-05-15 17:23 PDT, Andreas Kling
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-05-07 06:40:37 PDT

We're seeing quite a few spins below IconDatabase::retainIconForPageURL(), we should avoid blocking the main thread on this operation (and its release sibling.)
Comment 1 Andreas Kling 2012-05-15 17:23:03 PDT
Created attachment 142104 [details]

Here's one way we can do this- batch up the retain/release operations and execute them on the sync thread.
Comment 2 Brady Eidson 2012-05-17 13:06:51 PDT
Comment on attachment 142104 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=142104&action=review

> Source/WebCore/loader/icon/IconDatabase.cpp:1513
> +
> +    // NOTE: The caller is assumed to hold m_urlAndIconLock.
> +

In the past I thought we had a way to ASSERT this.

Do we still?
Comment 3 Andreas Kling 2012-05-17 14:49:10 PDT
Committed r117501: <http://trac.webkit.org/changeset/117501>