RESOLVED FIXED Bug 85794
MediaStream API: Adding the possibility of port specific information in MediaStreamDescriptor 
https://bugs.webkit.org/show_bug.cgi?id=85794
Summary MediaStream API: Adding the possibility of port specific information in Media...
Tommy Widenflycht
Reported 2012-05-07 05:20:36 PDT
To facilitate for ports I have added two fields to MediaStreamDescriptor: 1) A id (string) field where ports can give MSD an unique id. Needed because the label field is usable for this purpose. 2) An userData field (uint64_t) that can be used for whatever purpose is needed.
Attachments
Patch (9.08 KB, patch)
2012-05-07 05:27 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (10.76 KB, patch)
2012-05-08 06:59 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (7.14 KB, patch)
2012-05-09 01:07 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-05-07 05:27:55 PDT
Created attachment 140513 [details] Patch
WebKit Review Bot
Comment 2 2012-05-07 05:31:11 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-05-07 10:14:15 PDT
Comment on attachment 140513 [details] Patch The approach we usually use here is to create an ExtraData object that the client can subclass and use to store extra data on these objects. Take a look at WebURLRequest::ExtraData for an example of how this works.
Tommy Widenflycht
Comment 4 2012-05-08 06:59:25 PDT
Created attachment 140710 [details] Patch
Tommy Widenflycht
Comment 5 2012-05-08 07:01:16 PDT
Fixed. (In reply to comment #3) > (From update of attachment 140513 [details]) > The approach we usually use here is to create an ExtraData object that the client can subclass and use to store extra data on these objects. Take a look at WebURLRequest::ExtraData for an example of how this works.
Adam Barth
Comment 6 2012-05-08 09:29:00 PDT
Comment on attachment 140710 [details] Patch This looks fine, but please remove the m_id property. It doesn't seem to serve any purpose in WebKit. If the embedder wants to use an ID, it can put one in ExtraData.
Tommy Widenflycht
Comment 7 2012-05-09 01:07:02 PDT
Created attachment 140883 [details] Patch
Tommy Widenflycht
Comment 8 2012-05-09 01:07:40 PDT
(In reply to comment #6) > (From update of attachment 140710 [details]) > This looks fine, but please remove the m_id property. It doesn't seem to serve any purpose in WebKit. If the embedder wants to use an ID, it can put one in ExtraData. Fixed.
WebKit Review Bot
Comment 9 2012-05-09 08:48:20 PDT
Comment on attachment 140883 [details] Patch Clearing flags on attachment: 140883 Committed r116529: <http://trac.webkit.org/changeset/116529>
WebKit Review Bot
Comment 10 2012-05-09 08:48:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.