Bug 85782 - [CG] Separate image encoding from dataURL construction
Summary: [CG] Separate image encoding from dataURL construction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-07 02:08 PDT by noel gordon
Modified: 2012-05-07 16:05 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.80 KB, patch)
2012-05-07 02:09 PDT, noel gordon 		no flags Details | Formatted Diff | Diff
Patch for landing (3.85 KB, patch)
2012-05-07 14:36 PDT, noel gordon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2012-05-07 02:08:53 PDT 
[CG] Separate image encoding from dataURL construction
Comment 1 noel gordon 2012-05-07 02:09:48 PDT 
Created attachment 140495 [details]
Patch
Comment 2 Kenneth Russell 2012-05-07 13:13:48 PDT 
Comment on attachment 140495 [details]
Patch

Looks good to me.
Comment 3 WebKit Review Bot 2012-05-07 13:24:10 PDT 
Comment on attachment 140495 [details]
Patch

Rejecting attachment 140495 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12643420
Comment 4 noel gordon 2012-05-07 14:36:45 PDT 
Created attachment 140593 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-05-07 16:05:26 PDT 
Comment on attachment 140593 [details]
Patch for landing

Clearing flags on attachment: 140593

Committed r116364: <http://trac.webkit.org/changeset/116364>
Comment 6 WebKit Review Bot 2012-05-07 16:05:32 PDT 
All reviewed patches have been landed.  Closing bug.