Bug 85776 - Webaudio implemention for channel mixing lacks of something related to quad
Summary: Webaudio implemention for channel mixing lacks of something related to quad
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-06 23:20 PDT by Wang Jiajun
Modified: 2014-02-05 10:55 PST (History)
6 users (show)

See Also:

Attachments
Patch (124.49 KB, patch)
2012-05-06 23:25 PDT, Wang Jiajun 		no flags Details | Formatted Diff | Diff
Patch (124.44 KB, patch)
2012-06-07 00:40 PDT, Wang Jiajun 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wang Jiajun 2012-05-06 23:20:43 PDT 
Webaudio implemention for channel mixing lacks of something related to quad
Comment 1 Wang Jiajun 2012-05-06 23:25:53 PDT 
Created attachment 140482 [details]
Patch
Comment 2 Wang Jiajun 2012-05-07 01:29:30 PDT 
Currently, the support in channel mixing does not cover quad. But how they should be is described in the spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#UpMix

I find that it doesn't work correctly when up mixing from mono to quad, from quad to 5.1 and down mixing from quad to mono, from quad to stereo. So I have modified the AudioBus.cpp to make it work.

Additionally, I have written the corresponding layout tests for them. In the layout tests, I check the rendered data in js, not just render a .wav file. So I rewrite all the layout tests related to channel mixing and remove the corresponding .wav file.
Comment 3 Chris Rogers 2012-05-07 17:32:25 PDT 
Thanks for the patch.  I've looked quickly at it and it seems generally good.  I need to look in more detail...
Comment 4 Wang Jiajun 2012-06-07 00:40:44 PDT 
Created attachment 146221 [details]
Patch
Comment 5 Wang Jiajun 2012-06-07 01:20:54 PDT 
Fix a minor bug in my patch..Now the patch should be correct.

Chris, please have a look at the patch and let me know if it need improvement. Thanks.
Comment 6 Anders Carlsson 2014-02-05 10:55:31 PST 
Comment on attachment 146221 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.