Bug 85765 - [Chromium] Move blobRegistry to Platform.h
Summary: [Chromium] Move blobRegistry to Platform.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency treegraph
 
Reported: 2012-05-06 19:43 PDT by Mark Pilgrim (Google)
Modified: 2012-05-15 18:46 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.22 KB, patch)
2012-05-06 19:44 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (15.64 KB, patch)
2012-05-15 13:47 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (15.64 KB, patch)
2012-05-15 14:25 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-05-06 19:43:44 PDT
[Chromium] Move blobRegistry to Platform.h
Comment 1 Mark Pilgrim (Google) 2012-05-06 19:44:43 PDT
Created attachment 140458 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-06 19:46:35 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-05-06 20:40:59 PDT
Comment on attachment 140458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140458&action=review

> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:-53
> -class WebBlobRegistry;

Please move WebBlobRegistry.h and WebBlobData.h at the same time.  They're already in Source/WebKit/chromium/public/platform, so there shouldn't be any trouble with further dependencies.
Comment 4 Mark Pilgrim (Google) 2012-05-15 13:47:09 PDT
Created attachment 142044 [details]
Patch
Comment 5 Mark Pilgrim (Google) 2012-05-15 13:49:40 PDT
Comment on attachment 142044 [details]
Patch

Now moves WebBlogRegistry.h and WebBlobData.h.
Comment 6 Adam Barth 2012-05-15 14:07:23 PDT
Comment on attachment 142044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142044&action=review

> Source/Platform/chromium/public/Platform.h:82
> +

We've been trying to keep two blank lines between sections.
Comment 7 Adam Barth 2012-05-15 14:07:48 PDT
Looks great.  Thanks!
Comment 8 Mark Pilgrim (Google) 2012-05-15 14:25:48 PDT
Created attachment 142054 [details]
Patch
Comment 9 Mark Pilgrim (Google) 2012-05-15 14:27:13 PDT
Comment on attachment 142054 [details]
Patch

Now with more blank lines.
Comment 10 Adam Barth 2012-05-15 14:52:06 PDT
Comment on attachment 142054 [details]
Patch

Thanks.
Comment 11 WebKit Review Bot 2012-05-15 18:46:05 PDT
Comment on attachment 142054 [details]
Patch

Clearing flags on attachment: 142054

Committed r117202: <http://trac.webkit.org/changeset/117202>
Comment 12 WebKit Review Bot 2012-05-15 18:46:11 PDT
All reviewed patches have been landed.  Closing bug.