Bug 85765 – [Chromium] Move blobRegistry to Platform.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Mark Pilgrim (Google)]

[Chromium] Move blobRegistry to Platform.h

[Mark Pilgrim (Google)]

Created attachment 140458 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 140458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140458&action=review

> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:-53
> -class WebBlobRegistry;

Please move WebBlobRegistry.h and WebBlobData.h at the same time.  They're already in Source/WebKit/chromium/public/platform, so there shouldn't be any trouble with further dependencies.

[Mark Pilgrim (Google)]

Created attachment 142044 [details]
Patch

[Mark Pilgrim (Google)]

Comment on attachment 142044 [details]
Patch

Now moves WebBlogRegistry.h and WebBlobData.h.

[Adam Barth]

Comment on attachment 142044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142044&action=review

> Source/Platform/chromium/public/Platform.h:82
> +

We've been trying to keep two blank lines between sections.

[Adam Barth]

Looks great.  Thanks!

[Mark Pilgrim (Google)]

Created attachment 142054 [details]
Patch

[Mark Pilgrim (Google)]

Comment on attachment 142054 [details]
Patch

Now with more blank lines.

[Adam Barth]

Comment on attachment 142054 [details]
Patch

Thanks.

[WebKit Review Bot]

Comment on attachment 142054 [details]
Patch

Clearing flags on attachment: 142054

Committed r117202: <http://trac.webkit.org/changeset/117202>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.