Bug 85764 – [Chromium] Move createMessagePortChannel to Platform.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Mark Pilgrim (Google)]

[Chromium] Move createMessagePortChannel to Platform.h

[Mark Pilgrim (Google)]

Created attachment 140456 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 140456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140456&action=review

> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:-60
> -class WebMessagePortChannel; // FIXME: Does this belong in platform?

We'll also want to move WebMessagePortChannel and WebMessagePortChannelClient int Source/Platform/chromium/public as well.  They look like they'll move cleanly, so the answer to this comment seems to be "yes".

> Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:46
>  namespace WebCore {

Once you move WebMessagePortChannel into Source/Platform/chromium/public, you can move all this code into WebCore/platform where it belongs.  :)

[Mark Pilgrim (Google)]

Created attachment 142067 [details]
Patch

[Mark Pilgrim (Google)]

Comment on attachment 142067 [details]
Patch

Now moves WebMessagePortChannel and WebMessagePortChannelClient.

[Adam Barth]

Comment on attachment 142067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142067&action=review

> Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:46
>  namespace WebCore {

This patch is great.  Thanks!

A good followup patch might be to try to move this code in the WebCore namespace into Source/WebCore/platform/chromium.

[WebKit Review Bot]

Comment on attachment 142067 [details]
Patch

Clearing flags on attachment: 142067

Committed r117204: <http://trac.webkit.org/changeset/117204>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by 86559

[Mark Pilgrim (Google)]

Created attachment 146012 [details]
Patch

[Adam Barth]

Comment on attachment 146012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146012&action=review

> Source/WebKit/chromium/public/WebFrame.h:42
> +#include <public/WebMessagePortChannel.h>

The #includes in Source/WebKit/chromium/public should use forwarding headers, like WebURL.h above.

> Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:123
>  PlatformMessagePortChannel::PlatformMessagePortChannel()

This whole class should probably move into WebCore.

[Adam Barth]

(Feel free to move PlatformMessagePortChannel in a followup patch.)

[Mark Pilgrim (Google)]

Created attachment 146080 [details]
Patch

[Mark Pilgrim (Google)]

Comment on attachment 146080 [details]
Patch

reverted headers in chromium/public/

[WebKit Review Bot]

Comment on attachment 146080 [details]
Patch

Clearing flags on attachment: 146080

Committed r119666: <http://trac.webkit.org/changeset/119666>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.