Bug 85760 - [Chromium] Move fileSystem to Platform.h
Summary: [Chromium] Move fileSystem to Platform.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
Depends on:
Blocks: 82948
  Show dependency treegraph
Reported: 2012-05-06 19:08 PDT by Mark Pilgrim (Google)
Modified: 2012-05-07 12:11 PDT (History)
7 users (show)

See Also:

Patch (5.69 KB, patch)
2012-05-06 19:09 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
WIP patch (compile fails in WebFrame.h) (30.85 KB, patch)
2012-05-07 07:49 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch with forwarding header (28.79 KB, patch)
2012-05-07 11:14 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (28.30 KB, patch)
2012-05-07 11:36 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-05-06 19:08:15 PDT
[Chromium] Move fileSystem to Platform.h
Comment 1 Mark Pilgrim (Google) 2012-05-06 19:09:02 PDT
Created attachment 140451 [details]
Comment 2 WebKit Review Bot 2012-05-06 19:11:44 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-05-06 20:20:59 PDT
Comment on attachment 140451 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=140451&action=review

> Source/Platform/chromium/public/Platform.h:43
> +class WebFileSystem;

We should move WebFileSystem and its dependencies into Source/Platform/chromium/public as well.  I've already moved a bunch of them into Source/WebKit/chromium/public/platform, which is something of a staging area.  I think it would be ok to just move the WebFileSystem dependencies that are already in Source/WebKit/chromium/public/platform
Comment 4 Mark Pilgrim (Google) 2012-05-07 07:49:20 PDT
Created attachment 140528 [details]
WIP patch (compile fails in WebFrame.h)
Comment 5 Mark Pilgrim (Google) 2012-05-07 07:50:49 PDT
Work in progress, fails in WebFrame.h (can not find file WebFileSystem.h). Help?
Comment 6 WebKit Review Bot 2012-05-07 07:56:47 PDT
Comment on attachment 140528 [details]
WIP patch (compile fails in WebFrame.h)

Attachment 140528 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12655003
Comment 7 Adam Barth 2012-05-07 10:26:44 PDT
Comment on attachment 140528 [details]
WIP patch (compile fails in WebFrame.h)

View in context: https://bugs.webkit.org/attachment.cgi?id=140528&action=review

> Source/WebKit/chromium/public/WebFrame.h:40
>  #include "platform/WebCanvas.h"
> -#include "platform/WebFileSystem.h"
>  #include "platform/WebReferrerPolicy.h"
>  #include "platform/WebURL.h"
> +#include <public/WebFileSystem.h>

The trick is to leave these includes the way they are and to add a "forwarding" header like <http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/public/platform/WebURL.h>.  Once we've got everything in the right place, we'll remove the forwarding headers, but for now they help prevent these sorts of compile failures.
Comment 8 Mark Pilgrim (Google) 2012-05-07 11:14:13 PDT
Created attachment 140558 [details]
Patch with forwarding header
Comment 9 Adam Barth 2012-05-07 11:21:50 PDT
Comment on attachment 140558 [details]
Patch with forwarding header

View in context: https://bugs.webkit.org/attachment.cgi?id=140558&action=review

> Source/WebKit/chromium/public/WebCommonWorkerClient.h:35
> -#include "platform/WebFileSystem.h"
> +#include <public/WebFileSystem.h>

I'd leave the includes in the API using the forwarding header in case not all consumers of the API have their include paths set up to use the <public/...> version.

> Source/WebKit/chromium/src/AssertMatchingEnums.cpp:107
> +#include <public/WebFileSystem.h>

Changing the includes in the cpp files (and the non-public h files) is good though.
Comment 10 Mark Pilgrim (Google) 2012-05-07 11:36:26 PDT
Created attachment 140563 [details]
Comment 11 WebKit Review Bot 2012-05-07 12:11:09 PDT
Comment on attachment 140563 [details]

Clearing flags on attachment: 140563

Committed r116336: <http://trac.webkit.org/changeset/116336>
Comment 12 WebKit Review Bot 2012-05-07 12:11:14 PDT
All reviewed patches have been landed.  Closing bug.