Bug 85757 - [Chromium] Move idbFactory to Platform.h
Summary: [Chromium] Move idbFactory to Platform.h
Status: RESOLVED DUPLICATE of bug 105460
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency treegraph
 
Reported: 2012-05-06 18:51 PDT by Mark Pilgrim (Google)
Modified: 2012-12-19 13:37 PST (History)
7 users (show)

See Also:


Attachments
Patch (4.04 KB, patch)
2012-05-06 18:52 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
WIP Patch (121.23 KB, patch)
2012-12-18 12:16 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-05-06 18:51:21 PDT
[Chromium] Move idbFactory to Platform.h
Comment 1 Mark Pilgrim (Google) 2012-05-06 18:52:34 PDT
Created attachment 140448 [details]
Patch
Comment 2 Kentaro Hara 2012-05-06 18:55:18 PDT
Comment on attachment 140448 [details]
Patch

Looks OK.
Comment 3 WebKit Review Bot 2012-05-06 18:55:42 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Kentaro Hara 2012-05-06 18:56:40 PDT
Comment on attachment 140448 [details]
Patch

Removing r+ since it requires approval from API reviewers.
Comment 5 Build Bot 2012-05-06 19:13:28 PDT
Comment on attachment 140448 [details]
Patch

Attachment 140448 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12631904
Comment 6 Mark Pilgrim (Google) 2012-05-06 19:22:47 PDT
EWS bot result appears to be flake. Not sure why this patch would cause a segmentation fault.
Comment 7 Adam Barth 2012-05-06 20:29:30 PDT
Comment on attachment 140448 [details]
Patch

WebIDBFactory is a bit trickier.  Specifically, line 58 of WebKitPlatformSupport.h says:

class WebIDBFactory; // FIXME: Does this belong in platform?

The trouble is that WebIDBFactory::getDatabaseNames depends on WebFrame.  Source/Platform isn't allowed to know about Frames or WebFrames, so there's a bit of untangling to do.
Comment 8 Mark Pilgrim (Google) 2012-12-18 12:16:46 PST
Created attachment 179999 [details]
WIP Patch
Comment 9 Mark Pilgrim (Google) 2012-12-19 13:37:38 PST

*** This bug has been marked as a duplicate of bug 105460 ***