WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED LATER
85754
Update vsprops files to include all ENABLE_ macros
https://bugs.webkit.org/show_bug.cgi?id=85754
Summary
Update vsprops files to include all ENABLE_ macros
Eric Seidel (no email)
Reported
2012-05-06 16:57:30 PDT
Update vsprops files to include all ENABLE_ macros
Attachments
Patch
(18.15 KB, patch)
2012-05-06 17:03 PDT
,
Eric Seidel (no email)
rniwa
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2012-05-06 17:03:12 PDT
Created
attachment 140446
[details]
Patch
Ryosuke Niwa
Comment 2
2012-07-19 16:17:39 PDT
Comment on
attachment 140446
[details]
Patch rs=me.
Eric Seidel (no email)
Comment 3
2012-07-19 21:36:40 PDT
Comment on
attachment 140446
[details]
Patch I doubt this still applies.
WebKit Review Bot
Comment 4
2012-07-19 21:38:52 PDT
Comment on
attachment 140446
[details]
Patch Rejecting
attachment 140446
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: set 25 lines). Hunk #8 FAILED at 202. Hunk #9 succeeded at 272 (offset 35 lines). Hunk #10 succeeded at 297 (offset 35 lines). Hunk #11 succeeded at 342 (offset 40 lines). Hunk #12 succeeded at 397 (offset 50 lines). 2 out of 12 hunks FAILED -- saving rejects to file WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ryosuke Ni..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output:
http://queues.webkit.org/results/13317039
Eric Seidel (no email)
Comment 5
2013-01-04 01:58:22 PST
This would be nice to have, but I don't plan to clean this up and land it anytime soon.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug