Bug 85747 - [WK2] Push wheel events if there are too many in queue
: [WK2] Push wheel events if there are too many in queue
Status: RESOLVED FIXED
: WebKit
WebKit2
: 528+ (Nightly build)
: Macintosh Mac OS X 10.7
: P2 Normal
Assigned To:
:
: InRadar
:
:
  Show dependency treegraph
 
Reported: 2012-05-06 14:25 PST by
Modified: 2012-05-08 16:50 PST (History)


Attachments
Patch (13.70 KB, patch)
2012-05-06 14:39 PST, Jon Lee
no flags Review Patch | Details | Formatted Diff | Diff
Patch (12.53 KB, patch)
2012-05-06 22:23 PST, Jon Lee
andersca: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-05-06 14:25:33 PST
It is possible that a whole bunch of messages added to the message queue, or a series of long-running messages, cause unresponsiveness. The reason for this is that we have a scroll event waiting for acknowledgment from the web process before it sends the next event. And in the time between the user has scrolled, causing a large backlog of scroll events to be held in the UI process.

<rdar://problem/11390790>
------- Comment #1 From 2012-05-06 14:39:50 PST -------
Created an attachment (id=140435) [details]
Patch
------- Comment #2 From 2012-05-06 16:34:27 PST -------
(From update of attachment 140435 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=140435&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:1031
> +    class CoalescedWheelEvent : public RefCounted<CoalescedWheelEvent> {
> +    public:
> +        static PassRefPtr<CoalescedWheelEvent> create();
> +        CoalescedWheelEvent();
> +        virtual ~CoalescedWheelEvent();
> +        Vector<NativeWebWheelEvent> events;
> +    };

Is it necessary for this whole class to be public?  It seems like at the very least, the constructor should be private.  I'm also not clear on why this needs to be RefCounted.
------- Comment #3 From 2012-05-06 22:23:50 PST -------
Created an attachment (id=140475) [details]
Patch
------- Comment #4 From 2012-05-06 22:24:51 PST -------
(From update of attachment 140475 [details])
Originally had some problems using just the Vector but figured it out! Got rid of the internal class.
------- Comment #5 From 2012-05-08 16:50:02 PST -------
Committed r116466: <http://trac.webkit.org/changeset/116466>