Bug 85741 - Cleanup: Change boolean synchronous flag argument into enum in FileSystem API code
Summary: Cleanup: Change boolean synchronous flag argument into enum in FileSystem API...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kinuko Yasuda
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-06 11:02 PDT by Kinuko Yasuda
Modified: 2012-05-07 02:03 PDT (History)
0 users

See Also:


Attachments
Patch (19.97 KB, patch)
2012-05-06 11:06 PDT, Kinuko Yasuda
no flags Details | Formatted Diff | Diff
Patch (22.13 KB, patch)
2012-05-06 11:09 PDT, Kinuko Yasuda
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2012-05-06 11:02:17 PDT
Cleanup: Change boolean synchronous flag argument into enum in FileSystem API code

As in general using boolean argument is discouraged in WebKit.
Comment 1 Kinuko Yasuda 2012-05-06 11:06:10 PDT
Created attachment 140426 [details]
Patch
Comment 2 Kinuko Yasuda 2012-05-06 11:09:17 PDT
Created attachment 140427 [details]
Patch
Comment 3 David Levin 2012-05-06 11:41:15 PDT
Comment on attachment 140427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140427&action=review

> Source/WebCore/platform/FileSystemType.h:1
> +/*

I'm surprised that there aren't some build file changes to go along with this.

It would be nice to include it in build files. 

As long as this not being the those files doesn't break anything and it doesn't seem to, I would be fine with that as a follow up patch -- In fact I made this comment in the other patch so I'd land both and do one follow up patch for both of them :) (but no rush on that follow up patch).
Comment 4 Kinuko Yasuda 2012-05-07 01:56:56 PDT
Committed r116283: <http://trac.webkit.org/changeset/116283>
Comment 5 Kinuko Yasuda 2012-05-07 02:03:53 PDT
Comment on attachment 140427 [details]
Patch

Will create a follow-up patch for adding the header file to build/make files.