Bug 85728 – [Cairo] Implement ImageBuffer::copyImage for BackingStoreCopy == DontCopyBackingStore

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Martin Robinson]

This is useful for supporting faster texture uploads in the TextureMapper.

[Martin Robinson]

Created attachment 140420 [details]
Patch

[Noam Rosenthal]

Comment on attachment 140420 [details]
Patch

I'm ok with the TextureMapper changes, please have one of the Cairo folks review the other stuff :)

[Alejandro G. Castro]

Comment on attachment 140420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140420&action=review

LGTM, just a small comment.

> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:91
> +    return BitmapImage::create(cairo_surface_reference(m_data.m_surface)).leakRef();

I don't think the leakRef here is correct because it would returning an Image not an PassRefPtr<Image>, probably removing would be the right option.

[Martin Robinson]

Comment on attachment 140420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140420&action=review

>> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:91
>> +    return BitmapImage::create(cairo_surface_reference(m_data.m_surface)).leakRef();
> 
> I don't think the leakRef here is correct because it would returning an Image not an PassRefPtr<Image>, probably removing would be the right option.

BitmapImage::create is returning a PassRefPtr already so the leakRef is unnecessary here. I've fixed it and pushed. Thanks for the review!

[Martin Robinson]

Committed r116365: <http://trac.webkit.org/changeset/116365>