Bug 85725 - Eliminate duplicated code for culled line box in RenderInline
Summary: Eliminate duplicated code for culled line box in RenderInline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 66687 79150 84936
  Show dependency tree / graph
 
Reported: 2012-05-05 21:25 PDT by Tien-Ren Chen
Modified: 2012-06-24 01:12 PDT (History)
7 users (show)

See Also:

Attachments
Patch (23.27 KB, patch)
2012-05-05 21:34 PDT, Tien-Ren Chen 		no flags Details | Formatted Diff | Diff
Patch (23.28 KB, patch)
2012-05-10 14:44 PDT, Tien-Ren Chen 		no flags Details | Formatted Diff | Diff
Patch for landing (22.98 KB, patch)
2012-05-10 14:58 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tien-Ren Chen 2012-05-05 21:25:09 PDT 
Eliminate duplicated code for culled line box in RenderInline
Comment 1 Tien-Ren Chen 2012-05-05 21:34:11 PDT 
Created attachment 140417 [details]
Patch
Comment 2 Tien-Ren Chen 2012-05-08 14:04:34 PDT 
Can someone take a look at this please?

I think it is a good refactor to have one single function to generate all the local rects of a RenderInline.

There is one concern with this patch is the use of template and generator pattern, neither of them is used in WebKit. I use such seemingly over-complicated construct to make sure the compiled code will be as efficient as it was. If performance is not that much a concern I can make a simpler implementation that returns just a Vector<FloatRect>.
Comment 3 Adam Barth 2012-05-09 16:00:13 PDT 
@Eric: Would you be willing to look at this patch?
Comment 4 Eric Seidel (no email) 2012-05-09 16:39:02 PDT 
Comment on attachment 140417 [details]
Patch

Are you around #webkit that we could discuss this?
Comment 5 Tien-Ren Chen 2012-05-09 17:02:07 PDT 
(In reply to comment #4)
> (From update of attachment 140417 [details])
> Are you around #webkit that we could discuss this?

Sorry I'll need to go on an errand right now. I'll reach you tomorrow morning if it is convenient to you. Thanks!
Comment 6 Eric Seidel (no email) 2012-05-10 14:05:05 PDT 
Comment on attachment 140417 [details]
Patch

This is fantastic.  Thank you!
Comment 7 WebKit Review Bot 2012-05-10 14:15:00 PDT 
Comment on attachment 140417 [details]
Patch

Rejecting attachment 140417 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12671094
Comment 8 Tien-Ren Chen 2012-05-10 14:44:44 PDT 
Created attachment 141266 [details]
Patch
Comment 9 Tien-Ren Chen 2012-05-10 14:45:31 PDT 
Nothing changed. Just rebase and add back "Reviewed by" line.
Comment 10 Adam Barth 2012-05-10 14:58:35 PDT 
Created attachment 141271 [details]
Patch for landing
Comment 11 WebKit Review Bot 2012-05-10 19:07:22 PDT 
Comment on attachment 141271 [details]
Patch for landing

Clearing flags on attachment: 141271

Committed r116718: <http://trac.webkit.org/changeset/116718>
Comment 12 WebKit Review Bot 2012-05-10 19:07:28 PDT 
All reviewed patches have been landed.  Closing bug.