WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
85724
Implement the simple constructors WTFURL's KURL
https://bugs.webkit.org/show_bug.cgi?id=85724
Summary
Implement the simple constructors WTFURL's KURL
Benjamin Poulain
Reported
2012-05-05 17:58:45 PDT
Next step: be able to build KURL based on NSUrl and relative URL parsed from page.
Attachments
Patch
(11.01 KB, patch)
2012-05-05 18:33 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
Patch
(23.28 KB, patch)
2012-05-19 19:00 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
Patch
(28.47 KB, patch)
2012-06-10 15:02 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
Patch
(30.27 KB, patch)
2012-06-10 15:25 PDT
,
Benjamin Poulain
abarth
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2012-05-05 18:33:02 PDT
Created
attachment 140416
[details]
Patch
Benjamin Poulain
Comment 2
2012-05-05 18:33:51 PDT
Work in progress, I still need to add parsing of relative URLs.
Benjamin Poulain
Comment 3
2012-05-19 19:00:52 PDT
Created
attachment 142888
[details]
Patch
Benjamin Poulain
Comment 4
2012-06-10 15:02:10 PDT
Created
attachment 146750
[details]
Patch
Benjamin Poulain
Comment 5
2012-06-10 15:17:53 PDT
Unfortunately, even the simplest URL test require relative URL to work. So although I can now run the tests, none of them succeed. Next I'll have to fix parsing of relative URL.
Build Bot
Comment 6
2012-06-10 15:18:06 PDT
Comment on
attachment 146750
[details]
Patch
Attachment 146750
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/12938237
Benjamin Poulain
Comment 7
2012-06-10 15:25:08 PDT
Created
attachment 146753
[details]
Patch
Adam Barth
Comment 8
2012-06-11 01:07:29 PDT
Yeah, adding relative URLs is probably high on the TODO list.
Benjamin Poulain
Comment 9
2012-06-13 14:46:20 PDT
Committed
r120250
: <
http://trac.webkit.org/changeset/120250
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug