Bug 85724 - Implement the simple constructors WTFURL's KURL
Summary: Implement the simple constructors WTFURL's KURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-05 17:58 PDT by Benjamin Poulain
Modified: 2012-06-13 14:46 PDT (History)
1 user (show)

See Also:

Attachments
Patch (11.01 KB, patch)
2012-05-05 18:33 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (23.28 KB, patch)
2012-05-19 19:00 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (28.47 KB, patch)
2012-06-10 15:02 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (30.27 KB, patch)
2012-06-10 15:25 PDT, Benjamin Poulain 		abarth: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-05-05 17:58:45 PDT 
Next step: be able to build KURL based on NSUrl and relative URL parsed from page.
Comment 1 Benjamin Poulain 2012-05-05 18:33:02 PDT 
Created attachment 140416 [details]
Patch
Comment 2 Benjamin Poulain 2012-05-05 18:33:51 PDT 
Work in progress, I still need to add parsing of relative URLs.
Comment 3 Benjamin Poulain 2012-05-19 19:00:52 PDT 
Created attachment 142888 [details]
Patch
Comment 4 Benjamin Poulain 2012-06-10 15:02:10 PDT 
Created attachment 146750 [details]
Patch
Comment 5 Benjamin Poulain 2012-06-10 15:17:53 PDT 
Unfortunately, even the simplest URL test require relative URL to work. So although I can now run the tests, none of them succeed.

Next I'll have to fix parsing of relative URL.
Comment 6 Build Bot 2012-06-10 15:18:06 PDT 
Comment on attachment 146750 [details]
Patch

Attachment 146750 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12938237
Comment 7 Benjamin Poulain 2012-06-10 15:25:08 PDT 
Created attachment 146753 [details]
Patch
Comment 8 Adam Barth 2012-06-11 01:07:29 PDT 
Yeah, adding relative URLs is probably high on the TODO list.
Comment 9 Benjamin Poulain 2012-06-13 14:46:20 PDT 
Committed r120250: <http://trac.webkit.org/changeset/120250>