Bug 85716 - Web Inspector: do not create locations for resolved provisional breakpoints
Summary: Web Inspector: do not create locations for resolved provisional breakpoints
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-05 09:21 PDT by Pavel Feldman
Modified: 2012-05-07 23:30 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.25 KB, patch)
2012-05-05 09:25 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (6.97 KB, patch)
2012-05-05 09:56 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-05-05 09:21:59 PDT
Internal design, patch to follow.
Comment 1 Pavel Feldman 2012-05-05 09:25:59 PDT
Created attachment 140405 [details]
Patch
Comment 2 Pavel Feldman 2012-05-05 09:56:21 PDT
Created attachment 140409 [details]
Patch
Comment 3 Pavel Podivilov 2012-05-05 09:57:59 PDT
Comment on attachment 140409 [details]
Patch

looks good!
Comment 4 Yury Semikhatsky 2012-05-05 23:41:04 PDT
Comment on attachment 140409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140409&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:157
> +            breakpoints[i]._isProvisional = true;

Where is this flag reset?
Comment 5 Pavel Feldman 2012-05-07 23:26:21 PDT
Comment on attachment 140409 [details]
Patch

It is not reset, it dies along with the breakpoint object when provisional breakpoints are cleared.
Comment 6 Pavel Feldman 2012-05-07 23:29:57 PDT
Comment on attachment 140409 [details]
Patch

Clearing flags on attachment: 140409

Committed r116397: <http://trac.webkit.org/changeset/116397>
Comment 7 Pavel Feldman 2012-05-07 23:30:06 PDT
All reviewed patches have been landed.  Closing bug.