Bug 85708 - Web Inspector: get rid of InspectorAgent::emitCommitLoadIfNeeded method
Summary: Web Inspector: get rid of InspectorAgent::emitCommitLoadIfNeeded method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 85612
  Show dependency tree / graph
 
Reported: 2012-05-05 05:50 PDT by Yury Semikhatsky
Modified: 2012-05-11 01:41 PDT (History)
10 users (show)

See Also:

Attachments
Patch (10.20 KB, patch)
2012-05-07 01:12 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Patch for landing (8.87 KB, patch)
2012-05-10 05:06 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-05-05 05:50:23 PDT 
The method is special in that it is called by InspectorController when render process changes right after restore() has been called on all agents. The method makes front-end see the cross process navigation as one that doesn't lead to process change. Instead of having a special method we should send "reset" events from corresponding restore methods.
Comment 1 Yury Semikhatsky 2012-05-07 01:12:39 PDT 
Created attachment 140491 [details]
Patch
Comment 2 Pavel Feldman 2012-05-10 05:01:46 PDT 
Comment on attachment 140491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140491&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:97
> +        mainFrameNavigated(m_pageAgent->mainFrame()->loader()->documentLoader());

I don't think you need this.
Comment 3 Yury Semikhatsky 2012-05-10 05:06:59 PDT 
Created attachment 141148 [details]
Patch for landing
Comment 4 Yury Semikhatsky 2012-05-10 05:07:09 PDT 
(In reply to comment #2)
> (From update of attachment 140491 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140491&action=review
> 
> > Source/WebCore/inspector/InspectorResourceAgent.cpp:97
> > +        mainFrameNavigated(m_pageAgent->mainFrame()->loader()->documentLoader());
> 
> I don't think you need this.

Done.
Comment 5 Yury Semikhatsky 2012-05-11 01:41:27 PDT 
Committed r116740: <http://trac.webkit.org/changeset/116740>