Bug 85707 - Web Inspector: take timeline frame mode out of experimental
Summary: Web Inspector: take timeline frame mode out of experimental
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-05 05:48 PDT by Andrey Kosyakov
Modified: 2012-05-06 07:53 PDT (History)
10 users (show)

See Also:

Attachments
Patch (15.98 KB, patch)
2012-05-05 05:56 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-05-05 05:48:02 PDT 
- Remove "Vertical timeline overview" experiment;
- Add supportsFrameInstrumentation capability to InspectorTimelineAgent;
- Show frame mode selector conditionally on supportsFrameInstrumentation capability.
Comment 1 Andrey Kosyakov 2012-05-05 05:56:29 PDT 
Created attachment 140395 [details]
Patch
Comment 2 Pavel Feldman 2012-05-05 08:36:38 PDT 
Comment on attachment 140395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140395&action=review

> Source/WebCore/inspector/InspectorController.cpp:115
> +    m_agents.append(InspectorTimelineAgent::create(m_instrumentingAgents.get(), m_state.get(), InspectorTimelineAgent::PageInspector,

You make inspector controller timeline-details-aware. You should instead create a stub for worker's InspectorClient.
Comment 3 Andrey Kosyakov 2012-05-06 07:53:48 PDT 
Committed r116237: <http://trac.webkit.org/changeset/116237>