Bug 85697 - webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
Summary: webkitpy: Use os.pathsep instead of manually finding out the path separator i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-04 22:41 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-05-05 14:09 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2012-05-04 22:43 PDT, Raphael Kubo da Costa (:rakuco) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-05-04 22:41:22 PDT 
webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-05-04 22:43:01 PDT 
Created attachment 140381 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-05 10:56:04 PDT 
Comment on attachment 140381 [details]
Patch

Yay!  Except we really should have an os abstraction if this were unittested code (which some day it should be).  I believe FileSystem has .sep, so presumably eventually our FileSystem class will have pathsep.

Since this is not currently really unittestable code, I won't make you move it.  But some day we should. :)
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-05-05 14:08:12 PDT 
Committed r116229: <http://trac.webkit.org/changeset/116229>
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-05 14:09:11 PDT 
(In reply to comment #2)
> (From update of attachment 140381 [details])
> Yay!  Except we really should have an os abstraction if this were unittested code (which some day it should be).  I believe FileSystem has .sep, so presumably eventually our FileSystem class will have pathsep.
> 
> Since this is not currently really unittestable code, I won't make you move it.  But some day we should. :)

I've filed https://bugs.webkit.org/show_bug.cgi?id=85720 for that :-)