Adjust isPageBoxVisible tests to use Internals instead of LayoutTestController interface. In my humble opinion, isPageBoxVisible() is able to be supported by Internals. Because, it looks this function is implemented by WebCore layer, not WebKit layer. I'd like to know how do reviewers think about this patch.
Created attachment 140379 [details] Patch
Comment on attachment 140379 [details] Patch Attachment 140379 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12626348
Comment on attachment 140379 [details] Patch Attachment 140379 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12543527
Comment on attachment 140379 [details] Patch Attachment 140379 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12602355
Comment on attachment 140379 [details] Patch Attachment 140379 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12531360
Comment on attachment 140379 [details] Patch Attachment 140379 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12626362
Created attachment 140382 [details] Patch
Comment on attachment 140382 [details] Patch Attachment 140382 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12507439
Created attachment 140397 [details] Patch
Comment on attachment 140397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140397&action=review > Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm:-315 > - return [mainFrame isPageBoxVisible:pageNumber]; I can’t speak for the other ports, but for the Mac port, the isPageBoxVisible: method exists only to support this DumpRenderTree feature. So we should also be removing that method from WebKit entirely.
Comment on attachment 140397 [details] Patch Clearing flags on attachment: 140397 Committed r116246: <http://trac.webkit.org/changeset/116246>
All reviewed patches have been landed. Closing bug.
This patch broke the build on my machine due to leaving behind an unused function. I removed the function in <http://trac.webkit.org/changeset/116252>.
(In reply to comment #13) > This patch broke the build on my machine due to leaving behind an unused function. I removed the function in <http://trac.webkit.org/changeset/116252>. Thank you for your fix for build break.