Bug 85688 – Rename ICULocale to LocaleICU, part 1

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kent Tamura]

Rename ICULocale to LocaleICU, part 1

[Kent Tamura]

Created attachment 140372 [details]
Patch

[WebKit Review Bot]

Attachment 140372 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/text/LocaleICU.h:31:  #ifndef header guard has wrong style, please use: LocaleICU_h  [build/header_guard] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kentaro Hara]

Comment on attachment 140372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140372&action=review

> Source/WebCore/ChangeLog:8
> +        Rename it for consistency. Our convension is Foo<Platform>.{cpp,h}.

Nit: convention

> Source/WebCore/WebCore.gypi:4489
> +            'platform/text/LocaleICU.cpp',
> +            'platform/text/LocaleICU.h',

Nit: Alphabetical order please.

[Kent Tamura]

Comment on attachment 140372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140372&action=review

Thanks!

>> Source/WebCore/ChangeLog:8
>> +        Rename it for consistency. Our convension is Foo<Platform>.{cpp,h}.
> 
> Nit: convention

oops

>> Source/WebCore/WebCore.gypi:4489
>> +            'platform/text/LocaleICU.h',
> 
> Nit: Alphabetical order please.

Will fix.

[Kent Tamura]

Committed r116204: <http://trac.webkit.org/changeset/116204>