Bug 85688 - Rename ICULocale to LocaleICU, part 1
Summary: Rename ICULocale to LocaleICU, part 1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 85695
  Show dependency treegraph
 
Reported: 2012-05-04 18:22 PDT by Kent Tamura
Modified: 2012-05-04 20:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (46.03 KB, patch)
2012-05-04 18:33 PDT, Kent Tamura
haraken: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-05-04 18:22:10 PDT
Rename ICULocale to LocaleICU, part 1
Comment 1 Kent Tamura 2012-05-04 18:33:22 PDT
Created attachment 140372 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-04 18:38:23 PDT
Attachment 140372 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/text/LocaleICU.h:31:  #ifndef header guard has wrong style, please use: LocaleICU_h  [build/header_guard] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kentaro Hara 2012-05-04 19:41:44 PDT
Comment on attachment 140372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140372&action=review

> Source/WebCore/ChangeLog:8
> +        Rename it for consistency. Our convension is Foo<Platform>.{cpp,h}.

Nit: convention

> Source/WebCore/WebCore.gypi:4489
> +            'platform/text/LocaleICU.cpp',
> +            'platform/text/LocaleICU.h',

Nit: Alphabetical order please.
Comment 4 Kent Tamura 2012-05-04 19:48:59 PDT
Comment on attachment 140372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140372&action=review

Thanks!

>> Source/WebCore/ChangeLog:8
>> +        Rename it for consistency. Our convension is Foo<Platform>.{cpp,h}.
> 
> Nit: convention

oops

>> Source/WebCore/WebCore.gypi:4489
>> +            'platform/text/LocaleICU.h',
> 
> Nit: Alphabetical order please.

Will fix.
Comment 5 Kent Tamura 2012-05-04 19:53:23 PDT
Committed r116204: <http://trac.webkit.org/changeset/116204>