85658 – Painting collapsed borders during scrolling

RESOLVED FIXED 85658

Painting collapsed borders during scrolling

https://bugs.webkit.org/show_bug.cgi?id=85658

Summary Painting collapsed borders during scrolling

Robert Hogan

Reported 2012-05-04 13:30:00 PDT

If you make the viewport very small on the above test and scroll up and down the borders on the first table aren't painted properly. RenderTableSection::paintObject() needs to call paintCollapsedBorders() an extra row up beyond the one that's dirty in order to render the borders correctly I think.

Attachments
Patch (6.43 KB, patch) 2013-06-03 04:54 PDT, Robert Hogan	no flags	Details Formatted Diff Diff
Patch (6.48 KB, patch) 2013-06-03 04:59 PDT, Robert Hogan	no flags	Details Formatted Diff Diff
Patch (6.49 KB, patch) 2013-06-03 05:03 PDT, Robert Hogan	hyatt: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (465.33 KB, application/zip) 2013-06-03 06:42 PDT, Build Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Robert Hogan

Comment 1 2013-06-03 04:54:09 PDT

Created attachment 203575 [details] Patch

Robert Hogan

Comment 2 2013-06-03 04:59:50 PDT

Created attachment 203576 [details] Patch

Robert Hogan

Comment 3 2013-06-03 05:03:34 PDT

Created attachment 203578 [details] Patch

Build Bot

Comment 4 2013-06-03 06:42:25 PDT

Comment on attachment 203578 [details] Patch Attachment 203578 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/758287 New failing tests: fast/repaint/table-cell-collapsed-border-scroll.html

Build Bot

Comment 5 2013-06-03 06:42:27 PDT

Created attachment 203582 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Dave Hyatt

Comment 6 2013-06-03 10:34:48 PDT

Comment on attachment 203578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203578&action=review r=me > Source/WebCore/ChangeLog:10 > + WHen painting collapsed borders we need to paint the borders of the row above Little typo. "WHen" should be "When"

Robert Hogan

Comment 7 2013-06-11 11:11:57 PDT

Committed r151444: <http://trac.webkit.org/changeset/151444>

Note You need to log in before you can comment on or make changes to this bug.