Bug 85657 - Default container for horizontal cues
Summary: Default container for horizontal cues
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Victor Carbune
URL:
Keywords:
Depends on:
Blocks: 79751
  Show dependency treegraph
 
Reported: 2012-05-04 13:27 PDT by Victor Carbune
Modified: 2012-06-16 17:43 PDT (History)
7 users (show)

See Also:


Attachments
Implicit positioning (14.12 KB, text/plain)
2012-05-04 13:43 PDT, Victor Carbune
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Carbune 2012-05-04 13:27:31 PDT
The default renderer for the text track container should be a flexible box
container, such that cues without positioning information are implicitly
positioned on top of each other.
Comment 1 Victor Carbune 2012-05-04 13:43:49 PDT
Created attachment 140311 [details]
Implicit positioning
Comment 2 Eric Carlson 2012-05-07 08:51:01 PDT
Comment on attachment 140311 [details]
Implicit positioning

View in context: https://bugs.webkit.org/attachment.cgi?id=140311&action=review

> Source/WebCore/html/track/TextTrackCue.cpp:432
> +    // If cue is not associated with a text track, return รข1 and abort these
> +    // steps.

Oops, a non-ASCII character snuck in here for "-".

> Source/WebCore/html/track/TextTrackCue.cpp:439
> +    // Let n be the number of text tracks whose text track mode is showing or
> +    // showing by default and that are in the media element's list of text
> +    // tracks before track.
> +    int n = track()->trackIndex();

Won't this potentially include HIDDEN and DISABLED tracks? If this doesn't matter, please say why in the comment.
Comment 3 Victor Carbune 2012-06-16 17:42:43 PDT
As per our latest discussions, a default (nested) container is not the right way to implement the current form of the specification.