Bug 85649 - editing tests tend to be slow, should be marked as SLOW accordingly in test_expectations
Summary: editing tests tend to be slow, should be marked as SLOW accordingly in test_e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-04 12:16 PDT by Dirk Pranke
Modified: 2012-07-17 12:10 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-05-04 12:16:27 PDT
see bug 83076 for examples and some justification.
Comment 1 Tony Chang 2012-07-17 11:13:48 PDT
Reverted in http://trac.webkit.org/changeset/122859.  It's unfortunate that this has been in TestExpectations 2 months after bug 83076 was resolved.

It looks like all the tests with BUGWK83076 should be removed too.  I'll do that after verifying on the flakiness dashboard.

https://bugs.webkit.org/show_bug.cgi?id=83076#c20 : "...tests we mark as timeout/slow now will be forgotten."
Comment 2 Dirk Pranke 2012-07-17 11:55:11 PDT
I didn't mark the editing tests as slow because of the hardware flakiness, I did it because rniwa told me they should be considered slow. (see https://bugs.webkit.org/show_bug.cgi?id=83076#c15 ). Is that no longer the case?
Comment 3 Ryosuke Niwa 2012-07-17 12:01:29 PDT
(In reply to comment #2)
> I didn't mark the editing tests as slow because of the hardware flakiness, I did it because rniwa told me they should be considered slow. (see https://bugs.webkit.org/show_bug.cgi?id=83076#c15 ). Is that no longer the case?

It still is the case but if tests are passing fast enough, then we might as well remove SLOW.
Comment 4 Tony Chang 2012-07-17 12:01:41 PDT
(In reply to comment #2)
> I didn't mark the editing tests as slow because of the hardware flakiness, I did it because rniwa told me they should be considered slow. (see https://bugs.webkit.org/show_bug.cgi?id=83076#c15 ). Is that no longer the case?

They are integration tests (many LayoutTests are), but saying they are all slow is an over generalization.  Look at the end of the log file where we list the times of the slow tests:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win7/builds/18689/steps/webkit_tests/logs/stdio
Comment 5 Tony Chang 2012-07-17 12:02:36 PDT
We should just mark specific tests that are slow as SLOW.
Comment 6 Ryosuke Niwa 2012-07-17 12:04:36 PDT
(In reply to comment #5)
> We should just mark specific tests that are slow as SLOW.

I don't think the maintenance cost is worth the benefit. It's a pure noyance as far as I'm concerned. Alternatively, we should just increase the default timeout.
Comment 7 Dirk Pranke 2012-07-17 12:06:48 PDT
I'll let you two decide what you want to do. I don't have a dog in this fight :).
Comment 8 Ryosuke Niwa 2012-07-17 12:10:32 PDT
I'm not interested in discussing this matter either. If tests are fast now, or if something is willing to fix, then that's their problem.