Bug 85644 - [chromium] Revert compositor layer scrolling
Summary: [chromium] Revert compositor layer scrolling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sami Kyostila
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-04 10:53 PDT by Sami Kyostila
Modified: 2012-05-04 12:25 PDT (History)
6 users (show)

See Also:

Attachments
Patch (62.44 KB, patch)
2012-05-04 10:54 PDT, Sami Kyostila 		no flags Details | Formatted Diff | Diff
Patch (62.67 KB, patch)
2012-05-04 11:18 PDT, Sami Kyostila 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sami Kyostila 2012-05-04 10:53:06 PDT 
[chromium] Revert compositor layer scrolling
Comment 1 Sami Kyostila 2012-05-04 10:54:48 PDT 
Created attachment 140275 [details]
Patch
Comment 2 Andrei Popescu 2012-05-04 11:02:27 PDT 
LGTM...really sorry to see this reverted. Let's reland as soon as the crashers are fixed.
Comment 3 Steve Block 2012-05-04 11:05:18 PDT 
Comment on attachment 140275 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140275&action=review

rubber stamp

> Source/WebCore/ChangeLog:9
> +        trigger crashes:

Is there a bug which discusses this which you can link to?

> Source/WebCore/ChangeLog:13
> +            [chromium] Don't keep pointers to released layer tree

Please link to the revisions.
Comment 4 Sami Kyostila 2012-05-04 11:18:42 PDT 
Created attachment 140281 [details]
Patch
Comment 5 Sami Kyostila 2012-05-04 11:20:51 PDT 
I've improved the Changelog entry. Another look please?
Comment 6 Steve Block 2012-05-04 11:21:02 PDT 
Comment on attachment 140281 [details]
Patch

rubber stamp
Comment 7 WebKit Review Bot 2012-05-04 12:25:16 PDT 
Comment on attachment 140281 [details]
Patch

Clearing flags on attachment: 140281

Committed r116142: <http://trac.webkit.org/changeset/116142>
Comment 8 WebKit Review Bot 2012-05-04 12:25:21 PDT 
All reviewed patches have been landed.  Closing bug.