RESOLVED FIXED Bug 85630
Web Inspector: annotate ProfilerAgent. 
https://bugs.webkit.org/show_bug.cgi?id=85630
Summary Web Inspector: annotate ProfilerAgent.
Ilya Tikhonovsky
Reported 2012-05-04 09:00:17 PDT
%subj%
Attachments
Patch (17.32 KB, patch)
2012-05-04 09:20 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (20.65 KB, patch)
2012-05-04 09:35 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (21.50 KB, patch)
2012-05-04 09:46 PDT, Ilya Tikhonovsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-05-04 09:20:23 PDT
Created attachment 140249 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2012-05-04 09:26:50 PDT
Comment on attachment 140249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140249&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:367 > + this._profilesIdMap[this._makeKey('' + profile.uid, typeId)] = profile; You should probably fix the _makeKey() signature instead? > Source/WebCore/inspector/front-end/ProfilesPanel.js:547 > + var profile = this._profilesIdMap[this._makeKey('' + uid, WebInspector.HeapSnapshotProfileType.TypeId)]; Ditto > Source/WebCore/inspector/front-end/ProfilesPanel.js:558 > + var profile = this._profilesIdMap[this._makeKey('' + uid, WebInspector.HeapSnapshotProfileType.TypeId)]; Ditto
Ilya Tikhonovsky
Comment 3 2012-05-04 09:35:17 PDT
Created attachment 140255 [details] Patch
Ilya Tikhonovsky
Comment 4 2012-05-04 09:46:31 PDT
Created attachment 140257 [details] Patch
Ilya Tikhonovsky
Comment 5 2012-05-04 23:51:53 PDT
Committed r116210: <http://trac.webkit.org/changeset/116210>
Note You need to log in before you can comment on or make changes to this bug.