Bug 85630 - Web Inspector: annotate ProfilerAgent.
Summary: Web Inspector: annotate ProfilerAgent.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-04 09:00 PDT by Ilya Tikhonovsky
Modified: 2012-05-04 23:51 PDT (History)
10 users (show)

See Also:

Attachments
Patch (17.32 KB, patch)
2012-05-04 09:20 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Patch (20.65 KB, patch)
2012-05-04 09:35 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Patch (21.50 KB, patch)
2012-05-04 09:46 PDT, Ilya Tikhonovsky 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-05-04 09:00:17 PDT 
%subj%
Comment 1 Ilya Tikhonovsky 2012-05-04 09:20:23 PDT 
Created attachment 140249 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2012-05-04 09:26:50 PDT 
Comment on attachment 140249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140249&action=review

> Source/WebCore/inspector/front-end/ProfilesPanel.js:367
> +        this._profilesIdMap[this._makeKey('' + profile.uid, typeId)] = profile;

You should probably fix the _makeKey() signature instead?

> Source/WebCore/inspector/front-end/ProfilesPanel.js:547
> +        var profile = this._profilesIdMap[this._makeKey('' + uid, WebInspector.HeapSnapshotProfileType.TypeId)];

Ditto

> Source/WebCore/inspector/front-end/ProfilesPanel.js:558
> +        var profile = this._profilesIdMap[this._makeKey('' + uid, WebInspector.HeapSnapshotProfileType.TypeId)];

Ditto
Comment 3 Ilya Tikhonovsky 2012-05-04 09:35:17 PDT 
Created attachment 140255 [details]
Patch
Comment 4 Ilya Tikhonovsky 2012-05-04 09:46:31 PDT 
Created attachment 140257 [details]
Patch
Comment 5 Ilya Tikhonovsky 2012-05-04 23:51:53 PDT 
Committed r116210: <http://trac.webkit.org/changeset/116210>