Bug 85621 - Web Inspector: use single method for retrieving evaluation context in the runtime agent
Summary: Web Inspector: use single method for retrieving evaluation context in the run...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 85612
  Show dependency tree / graph
 
Reported: 2012-05-04 07:29 PDT by Yury Semikhatsky
Modified: 2012-05-04 07:36 PDT (History)
10 users (show)

See Also:

Attachments
Patch (6.74 KB, patch)
2012-05-04 07:31 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-05-04 07:29:48 PDT 
It is a small refactoring that makes things a bit simpler.
Comment 1 Yury Semikhatsky 2012-05-04 07:31:34 PDT 
Created attachment 140220 [details]
Patch
Comment 2 Pavel Feldman 2012-05-04 07:32:51 PDT 
Comment on attachment 140220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140220&action=review

> Source/WebCore/inspector/PageRuntimeAgent.cpp:55
> +ScriptState* PageRuntimeAgent::getScriptStateForEval(ErrorString* errorString, const String* frameId)

we don't use get prefixes in WebKit.
Comment 3 Yury Semikhatsky 2012-05-04 07:34:13 PDT 
(In reply to comment #2)
> (From update of attachment 140220 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140220&action=review
> 
> > Source/WebCore/inspector/PageRuntimeAgent.cpp:55
> > +ScriptState* PageRuntimeAgent::getScriptStateForEval(ErrorString* errorString, const String* frameId)
> 
> we don't use get prefixes in WebKit.

Fixed.
Comment 4 Yury Semikhatsky 2012-05-04 07:36:04 PDT 
Committed r116099: <http://trac.webkit.org/changeset/116099>