The media/video-poster-blocked-by-willsendrequest.html test is flaky on the EFL build bot. It appears the flakyness is caused by media/crash-closing-page-with-media-as-plugin-fallback.html: This succeeds: ./Tools/Scripts/run-webkit-tests --efl -p media/video-poster-blocked-by-willsendrequest.html But this willl cause media/video-poster-blocked-by-willsendrequest.html to fail: ./Tools/Scripts/run-webkit-tests --efl -p LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback.html media/video-poster-blocked-by-willsendrequest.html
This is related to the poster parameter of the video tag because the following removes flakyness: diff --git a/LayoutTests/media/resources/video-with-poster-as-object-fallback.html b/LayoutTests/media/resources/video-with-poster-as-object-fallback.html index 7f6983b..b64bcfd 100644 --- a/LayoutTests/media/resources/video-with-poster-as-object-fallback.html +++ b/LayoutTests/media/resources/video-with-poster-as-object-fallback.html @@ -1,7 +1,7 @@ <script src="../media-file.js"></script> <body onload="opener.childLoaded()"> <object height="500" width="500"> -<video id="theVideo" controls="controls" poster="../content/abe.png" preload="auto"> +<video id="theVideo" controls="controls" preload="auto"> </video> <script> document.getElementById("theVideo").src = findMediaFile('video', '../content/counting');
Same flakyness seems to happen on Lion (Bug 82976)
Created attachment 140212 [details] Patch The issue was caused by the fact that media/crash-closing-page-with-media-as-plugin-fallback.html and media/video-poster-blocked-by-willsendrequest.html use the same PNG file as poster attribute in the video tag. The PNG file gets cached when the first test is executed and this somehow causes the second test to fail. I addressed this by clearing the caches between the tests in DumpRenderTreeChrome::resetDefaultsToConsistentValues(). The tests are no longer flaky.
Comment on attachment 140212 [details] Patch Looks good!
BTW, it'd be awesome if you could add the explanation in comment #3 to the ChangeLog.
Created attachment 140214 [details] Patch Update changelog as advised.
Comment on attachment 140214 [details] Patch rs=me
Comment on attachment 140214 [details] Patch Clearing flags on attachment: 140214 Committed r116296: <http://trac.webkit.org/changeset/116296>
All reviewed patches have been landed. Closing bug.