Bug 85609 - [EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
Summary: [EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Blocks: 85601
  Show dependency treegraph
Reported: 2012-05-04 05:21 PDT by Chris Dumez
Modified: 2012-05-07 04:26 PDT (History)
5 users (show)

See Also:

Patch (1.40 KB, patch)
2012-05-04 06:38 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2012-05-04 06:50 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-05-04 05:21:55 PDT
The media/video-poster-blocked-by-willsendrequest.html test is flaky on the EFL build bot.

It appears the flakyness is caused by media/crash-closing-page-with-media-as-plugin-fallback.html:

This succeeds:
./Tools/Scripts/run-webkit-tests --efl -p media/video-poster-blocked-by-willsendrequest.html

But this willl cause media/video-poster-blocked-by-willsendrequest.html to fail:
./Tools/Scripts/run-webkit-tests --efl -p LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback.html media/video-poster-blocked-by-willsendrequest.html
Comment 1 Chris Dumez 2012-05-04 05:24:05 PDT
This is related to the poster parameter of the video tag because the following removes flakyness:

diff --git a/LayoutTests/media/resources/video-with-poster-as-object-fallback.html b/LayoutTests/media/resources/video-with-poster-as-object-fallback.html
index 7f6983b..b64bcfd 100644
--- a/LayoutTests/media/resources/video-with-poster-as-object-fallback.html
+++ b/LayoutTests/media/resources/video-with-poster-as-object-fallback.html
@@ -1,7 +1,7 @@
 <script src="../media-file.js"></script>
 <body onload="opener.childLoaded()">
 <object height="500" width="500">
-<video id="theVideo" controls="controls" poster="../content/abe.png" preload="auto">
+<video id="theVideo" controls="controls" preload="auto">
 document.getElementById("theVideo").src = findMediaFile('video', '../content/counting');
Comment 2 Chris Dumez 2012-05-04 05:28:52 PDT
Same flakyness seems to happen on Lion (Bug 82976)
Comment 3 Chris Dumez 2012-05-04 06:38:12 PDT
Created attachment 140212 [details]

The issue was caused by the fact that media/crash-closing-page-with-media-as-plugin-fallback.html and media/video-poster-blocked-by-willsendrequest.html use the same PNG file as poster attribute in the video tag. The PNG file gets cached when the first test is executed and this somehow causes the second test to fail. I addressed this by clearing the caches between the tests in DumpRenderTreeChrome::resetDefaultsToConsistentValues().

The tests are no longer flaky.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-04 06:41:42 PDT
Comment on attachment 140212 [details]

Looks good!
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-05-04 06:42:11 PDT
BTW, it'd be awesome if you could add the explanation in comment #3 to the ChangeLog.
Comment 6 Chris Dumez 2012-05-04 06:50:49 PDT
Created attachment 140214 [details]

Update changelog as advised.
Comment 7 Simon Hausmann 2012-05-07 04:20:00 PDT
Comment on attachment 140214 [details]

Comment 8 WebKit Review Bot 2012-05-07 04:25:52 PDT
Comment on attachment 140214 [details]

Clearing flags on attachment: 140214

Committed r116296: <http://trac.webkit.org/changeset/116296>
Comment 9 WebKit Review Bot 2012-05-07 04:26:08 PDT
All reviewed patches have been landed.  Closing bug.