Bug 85608 - [EFL] [DRT] Clear extra views before setting a blank page
Summary: [EFL] [DRT] Clear extra views before setting a blank page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks: 85601
  Show dependency tree / graph
 
Reported: 2012-05-04 05:15 PDT by Thiago Marcos P. Santos
Modified: 2012-05-08 02:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.15 KB, patch)
2012-05-07 09:03 PDT, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-05-04 05:15:05 PDT 
I found out so far that running fast/frames/frame-crash-with-page-cache.html before it in the same test set makes it fail.

./Tools/Scripts/run-webkit-tests --efl --debug --no-retry-failures --no-new-test-results fast/frames/frame-crash-with-page-cache.html fast/frames/frame-dead-region.html --> FAIL
./Tools/Scripts/run-webkit-tests --efl --debug --no-retry-failures --no-new-test-results fast/frames/frame-dead-region.html --> OK

It's likely to be some leftover settings from the previous test.
Comment 1 Thiago Marcos P. Santos 2012-05-07 09:03:19 PDT 
Created attachment 140534 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-07 09:23:06 PDT 
Comment on attachment 140534 [details]
Patch

Looks OK.
Comment 3 Chris Dumez 2012-05-07 23:20:03 PDT 
It is even crashing now for some reason:

Regressions: Unexpected crashes : (1)
  fast/frames/frame-dead-region.html = CRASH
Comment 4 Gyuyoung Kim 2012-05-08 00:12:49 PDT 
Comment on attachment 140534 [details]
Patch

LGTM.
Comment 5 Gyuyoung Kim 2012-05-08 00:32:39 PDT 
(In reply to comment #3)
> It is even crashing now for some reason:
> 
> Regressions: Unexpected crashes : (1)
>   fast/frames/frame-dead-region.html = CRASH

There is no crash on my linux box.
Comment 6 Chris Dumez 2012-05-08 01:06:55 PDT 
(In reply to comment #5)
> (In reply to comment #3)
> > It is even crashing now for some reason:
> > 
> > Regressions: Unexpected crashes : (1)
> >   fast/frames/frame-dead-region.html = CRASH
> 
> There is no crash on my linux box.

This is on our Debug build bot, not my box.
Comment 7 Kenneth Rohde Christiansen 2012-05-08 01:15:50 PDT 
Comment on attachment 140534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140534&action=review

> Tools/DumpRenderTree/efl/DumpRenderTree.cpp:253
> +    browser->clearExtraViews();

clearAdditionalViews() ?
Comment 8 Thiago Marcos P. Santos 2012-05-08 01:21:30 PDT 
(In reply to comment #7)
> (From update of attachment 140534 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140534&action=review
> 
> > Tools/DumpRenderTree/efl/DumpRenderTree.cpp:253
> > +    browser->clearExtraViews();
> 
> clearAdditionalViews() ?

I used "Extra" because the member variable "m_extraViews" and the getter "DumpRenderTreeChrome::extraViews()".
Comment 9 WebKit Review Bot 2012-05-08 02:27:47 PDT 
Comment on attachment 140534 [details]
Patch

Clearing flags on attachment: 140534

Committed r116407: <http://trac.webkit.org/changeset/116407>
Comment 10 WebKit Review Bot 2012-05-08 02:27:52 PDT 
All reviewed patches have been landed.  Closing bug.