Bug 85608 – [EFL] [DRT] Clear extra views before setting a blank page

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Thiago Marcos P. Santos]

I found out so far that running fast/frames/frame-crash-with-page-cache.html before it in the same test set makes it fail.

./Tools/Scripts/run-webkit-tests --efl --debug --no-retry-failures --no-new-test-results fast/frames/frame-crash-with-page-cache.html fast/frames/frame-dead-region.html --> FAIL
./Tools/Scripts/run-webkit-tests --efl --debug --no-retry-failures --no-new-test-results fast/frames/frame-dead-region.html --> OK

It's likely to be some leftover settings from the previous test.

[Thiago Marcos P. Santos]

Created attachment 140534 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 140534 [details]
Patch

Looks OK.

[Chris Dumez]

It is even crashing now for some reason:

Regressions: Unexpected crashes : (1)
  fast/frames/frame-dead-region.html = CRASH

[Gyuyoung Kim]

Comment on attachment 140534 [details]
Patch

LGTM.

[Gyuyoung Kim]

(In reply to comment #3)
> It is even crashing now for some reason:
> 
> Regressions: Unexpected crashes : (1)
>   fast/frames/frame-dead-region.html = CRASH

There is no crash on my linux box.

[Chris Dumez]

(In reply to comment #5)
> (In reply to comment #3)
> > It is even crashing now for some reason:
> > 
> > Regressions: Unexpected crashes : (1)
> >   fast/frames/frame-dead-region.html = CRASH
> 
> There is no crash on my linux box.

This is on our Debug build bot, not my box.

[Kenneth Rohde Christiansen]

Comment on attachment 140534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140534&action=review

> Tools/DumpRenderTree/efl/DumpRenderTree.cpp:253
> +    browser->clearExtraViews();

clearAdditionalViews() ?

[Thiago Marcos P. Santos]

(In reply to comment #7)
> (From update of attachment 140534 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140534&action=review
> 
> > Tools/DumpRenderTree/efl/DumpRenderTree.cpp:253
> > +    browser->clearExtraViews();
> 
> clearAdditionalViews() ?

I used "Extra" because the member variable "m_extraViews" and the getter "DumpRenderTreeChrome::extraViews()".

[WebKit Review Bot]

Comment on attachment 140534 [details]
Patch

Clearing flags on attachment: 140534

Committed r116407: <http://trac.webkit.org/changeset/116407>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.