Bug 85607 - [Qt] Qt support for new Layout types
Summary: [Qt] Qt support for new Layout types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-04 05:09 PDT by Allan Sandfeld Jensen
Modified: 2012-05-11 07:10 PDT (History)
2 users (show)

See Also:


Attachments
Patch (12.97 KB, patch)
2012-05-04 05:16 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch (11.62 KB, patch)
2012-05-11 01:02 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-05-04 05:09:19 PDT
New layout types has recently been added to replace IntPoint et al. The new types however does not yet support conversion to or from Qt datatypes like the old ones and can not be streamed to QDebug.
Comment 1 Allan Sandfeld Jensen 2012-05-04 05:16:56 PDT
Created attachment 140194 [details]
Patch
Comment 2 Early Warning System Bot 2012-05-04 05:49:59 PDT
Comment on attachment 140194 [details]
Patch

Attachment 140194 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12633134
Comment 3 Kenneth Rohde Christiansen 2012-05-04 05:54:44 PDT
Comment on attachment 140194 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140194&action=review

> Source/WebCore/platform/graphics/qt/FractionalLayoutPointQt.cpp:2
> + * Copyright (C) 2006 Zack Rusin <zack@kde.org>

I wonder how much of this code is actually by Zack, if any?

> Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:37
> +FractionalLayoutSize::FractionalLayoutSize(const QSizeF& r)

Doesn't size make more sense than r

> Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:50
> +// vim: ts=4 sw=4 et

Are we supposed to add this? I think we should leave it out
Comment 4 Allan Sandfeld Jensen 2012-05-04 06:00:32 PDT
(In reply to comment #3)
> (From update of attachment 140194 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140194&action=review
> 
> > Source/WebCore/platform/graphics/qt/FractionalLayoutPointQt.cpp:2
> > + * Copyright (C) 2006 Zack Rusin <zack@kde.org>
> 
> I wonder how much of this code is actually by Zack, if any?
> 
I copied the files from the similar versions of IntSomethingQt.cpp, the copyright is just copied from there and updated. The code is boiler plate enough that copyright probably doesn't matter though.

> > Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:37
> > +FractionalLayoutSize::FractionalLayoutSize(const QSizeF& r)
> 
> Doesn't size make more sense than r
> 
Makes sense.

> > Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:50
> > +// vim: ts=4 sw=4 et
> 
> Are we supposed to add this? I think we should leave it out
Okay, I was just copying the file.
Comment 5 Simon Hausmann 2012-05-09 00:45:01 PDT
Comment on attachment 140194 [details]
Patch

Taking this out of the review queue due to the EWS failure (missing #include?). Otherwise I think the patch is okay (modulo Kenneth's comments :)
Comment 6 Allan Sandfeld Jensen 2012-05-11 01:02:39 PDT
Created attachment 141346 [details]
Patch
Comment 7 Simon Hausmann 2012-05-11 01:17:06 PDT
Comment on attachment 141346 [details]
Patch

let's wait for EWS results before landing
Comment 8 WebKit Review Bot 2012-05-11 07:10:43 PDT
Comment on attachment 141346 [details]
Patch

Clearing flags on attachment: 141346

Committed r116767: <http://trac.webkit.org/changeset/116767>
Comment 9 WebKit Review Bot 2012-05-11 07:10:47 PDT
All reviewed patches have been landed.  Closing bug.