New layout types has recently been added to replace IntPoint et al. The new types however does not yet support conversion to or from Qt datatypes like the old ones and can not be streamed to QDebug.
Created attachment 140194 [details] Patch
Comment on attachment 140194 [details] Patch Attachment 140194 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12633134
Comment on attachment 140194 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140194&action=review > Source/WebCore/platform/graphics/qt/FractionalLayoutPointQt.cpp:2 > + * Copyright (C) 2006 Zack Rusin <zack@kde.org> I wonder how much of this code is actually by Zack, if any? > Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:37 > +FractionalLayoutSize::FractionalLayoutSize(const QSizeF& r) Doesn't size make more sense than r > Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:50 > +// vim: ts=4 sw=4 et Are we supposed to add this? I think we should leave it out
(In reply to comment #3) > (From update of attachment 140194 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140194&action=review > > > Source/WebCore/platform/graphics/qt/FractionalLayoutPointQt.cpp:2 > > + * Copyright (C) 2006 Zack Rusin <zack@kde.org> > > I wonder how much of this code is actually by Zack, if any? > I copied the files from the similar versions of IntSomethingQt.cpp, the copyright is just copied from there and updated. The code is boiler plate enough that copyright probably doesn't matter though. > > Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:37 > > +FractionalLayoutSize::FractionalLayoutSize(const QSizeF& r) > > Doesn't size make more sense than r > Makes sense. > > Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:50 > > +// vim: ts=4 sw=4 et > > Are we supposed to add this? I think we should leave it out Okay, I was just copying the file.
Comment on attachment 140194 [details] Patch Taking this out of the review queue due to the EWS failure (missing #include?). Otherwise I think the patch is okay (modulo Kenneth's comments :)
Created attachment 141346 [details] Patch
Comment on attachment 141346 [details] Patch let's wait for EWS results before landing
Comment on attachment 141346 [details] Patch Clearing flags on attachment: 141346 Committed r116767: <http://trac.webkit.org/changeset/116767>
All reviewed patches have been landed. Closing bug.