Bug 85607 – [Qt] Qt support for new Layout types

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Allan Sandfeld Jensen]

New layout types has recently been added to replace IntPoint et al. The new types however does not yet support conversion to or from Qt datatypes like the old ones and can not be streamed to QDebug.

[Allan Sandfeld Jensen]

Created attachment 140194 [details]
Patch

[Early Warning System Bot]

Comment on attachment 140194 [details]
Patch

Attachment 140194 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12633134

[Kenneth Rohde Christiansen]

Comment on attachment 140194 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140194&action=review

> Source/WebCore/platform/graphics/qt/FractionalLayoutPointQt.cpp:2
> + * Copyright (C) 2006 Zack Rusin <[e-mail]>

I wonder how much of this code is actually by Zack, if any?

> Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:37
> +FractionalLayoutSize::FractionalLayoutSize(const QSizeF& r)

Doesn't size make more sense than r

> Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:50
> +// vim: ts=4 sw=4 et

Are we supposed to add this? I think we should leave it out

[Allan Sandfeld Jensen]

(In reply to comment #3)
> (From update of attachment 140194 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140194&action=review
> 
> > Source/WebCore/platform/graphics/qt/FractionalLayoutPointQt.cpp:2
> > + * Copyright (C) 2006 Zack Rusin <[e-mail]>
> 
> I wonder how much of this code is actually by Zack, if any?
> 
I copied the files from the similar versions of IntSomethingQt.cpp, the copyright is just copied from there and updated. The code is boiler plate enough that copyright probably doesn't matter though.

> > Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:37
> > +FractionalLayoutSize::FractionalLayoutSize(const QSizeF& r)
> 
> Doesn't size make more sense than r
> 
Makes sense.

> > Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp:50
> > +// vim: ts=4 sw=4 et
> 
> Are we supposed to add this? I think we should leave it out
Okay, I was just copying the file.

[Simon Hausmann]

Comment on attachment 140194 [details]
Patch

Taking this out of the review queue due to the EWS failure (missing #include?). Otherwise I think the patch is okay (modulo Kenneth's comments :)

[Allan Sandfeld Jensen]

Created attachment 141346 [details]
Patch

[Simon Hausmann]

Comment on attachment 141346 [details]
Patch

let's wait for EWS results before landing

[WebKit Review Bot]

Comment on attachment 141346 [details]
Patch

Clearing flags on attachment: 141346

Committed r116767: <http://trac.webkit.org/changeset/116767>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.