RESOLVED INVALID 85590
Web Inspector: reconnect websocket 
https://bugs.webkit.org/show_bug.cgi?id=85590
Summary Web Inspector: reconnect websocket
Karl Skomski
Reported 2012-05-04 01:17:50 PDT
Web Inspector: reconnect websocket
Attachments
Patch (2.00 KB, patch)
2012-05-04 01:20 PDT, Karl Skomski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Karl Skomski
Comment 1 2012-05-04 01:20:05 PDT
Created attachment 140177 [details] Patch
Karl Skomski
Comment 2 2012-05-04 01:21:24 PDT
*** Bug 85589 has been marked as a duplicate of this bug. ***
alFReD NSH
Comment 3 2012-08-26 02:25:33 PDT
`InspectorFrontendHost.sendMessageToBackend = WebInspector.socket.send.bind(WebInspector.socket);` is a duplicate line. To refactor this, better to call a callback argument, on open event and `WebInspector.doLoadedDone();` on it.
alFReD NSH
Comment 4 2012-08-26 02:29:37 PDT
This is what I mean: Change the function call to this: createWebSocket(function () { WebInspector.doLoadedDone(); }); and then in createWebSocket -> function createWebSocket(onopen) { ... WebInspector.socket.onopen = function() { InspectorFrontendHost.sendMessageToBackend = ... opopen.call(this); } }
alFReD NSH
Comment 5 2012-08-26 02:47:37 PDT
Also your function definitions doesn't match the webkit style: http://www.webkit.org/coding/coding-style.html#braces
Brian Burg
Comment 6 2014-12-12 14:38:32 PST
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.
Note You need to log in before you can comment on or make changes to this bug.