Bug 85572 - [BlackBerry] Enable credential persistance and auto fill
Summary: [BlackBerry] Enable credential persistance and auto fill
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-03 19:54 PDT by Jonathan Dong
Modified: 2012-05-06 15:05 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.15 KB, patch)
2012-05-03 20:45 PDT, Jonathan Dong 		no flags Details | Formatted Diff | Diff
Patch (3.21 KB, patch)
2012-05-04 07:56 PDT, Jonathan Dong 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dong 2012-05-03 19:54:46 PDT 
enable credential persistance and auto fill feature in build system
Comment 1 Jonathan Dong 2012-05-03 20:45:23 PDT 
Created attachment 140153 [details]
Patch
Comment 2 Rob Buis 2012-05-04 07:18:08 PDT 
Comment on attachment 140153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140153&action=review

Looks good, wondering about the minor fix line?

> Source/WebKit/blackberry/ChangeLog:10
> +        This is a minor fix by the way.

I dont get this line? Better clear it up before landing.
Comment 3 Jonathan Dong 2012-05-04 07:42:05 PDT 
Comment on attachment 140153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140153&action=review

>> Source/WebKit/blackberry/ChangeLog:10
>> +        This is a minor fix by the way.
> 
> I dont get this line? Better clear it up before landing.

Thanks Rob, calling setAutofilled() on the input element will get it painted with yellow background which can notify user this input is auto filled by browser. I forget to add this in the former patches. will explain this in changelog with my next patch.
Comment 4 Jonathan Dong 2012-05-04 07:56:13 PDT 
Created attachment 140225 [details]
Patch
Comment 5 Rob Buis 2012-05-04 08:07:12 PDT 
Comment on attachment 140225 [details]
Patch

Looks good, I hope Leo, Charles or Mary can help with landing.
Comment 6 Jonathan Dong 2012-05-06 03:27:46 PDT 
hi Rob, do you know what's wrong with it? Charles has helped on cq+ this patch in the early morning this Saturday, but it hasn't get landed yet until now, and there's no status update. Do I need to re-submit it?

and we are not able to see the build status here in china, :(
Comment 7 Rob Buis 2012-05-06 09:23:42 PDT 
Hi Jonathan,

(In reply to comment #6)
> hi Rob, do you know what's wrong with it? Charles has helped on cq+ this patch in the early morning this Saturday, but it hasn't get landed yet until now, and there's no status update. Do I need to re-submit it?
> 
> and we are not able to see the build status here in china, :(

Maybe the queue is stuck, I'll keep an eye on it.
Comment 8 WebKit Review Bot 2012-05-06 15:04:54 PDT 
Comment on attachment 140225 [details]
Patch

Clearing flags on attachment: 140225

Committed r116241: <http://trac.webkit.org/changeset/116241>
Comment 9 WebKit Review Bot 2012-05-06 15:05:01 PDT 
All reviewed patches have been landed.  Closing bug.