RESOLVED FIXED 85572
[BlackBerry] Enable credential persistance and auto fill 
https://bugs.webkit.org/show_bug.cgi?id=85572
Summary [BlackBerry] Enable credential persistance and auto fill
Jonathan Dong
Reported 2012-05-03 19:54:46 PDT
enable credential persistance and auto fill feature in build system
Attachments
Patch (3.15 KB, patch)
2012-05-03 20:45 PDT, Jonathan Dong 		no flags
DetailsFormatted DiffDiff
Patch (3.21 KB, patch)
2012-05-04 07:56 PDT, Jonathan Dong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Dong
Comment 1 2012-05-03 20:45:23 PDT
Created attachment 140153 [details] Patch
Rob Buis
Comment 2 2012-05-04 07:18:08 PDT
Comment on attachment 140153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140153&action=review Looks good, wondering about the minor fix line? > Source/WebKit/blackberry/ChangeLog:10 > + This is a minor fix by the way. I dont get this line? Better clear it up before landing.
Jonathan Dong
Comment 3 2012-05-04 07:42:05 PDT
Comment on attachment 140153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140153&action=review >> Source/WebKit/blackberry/ChangeLog:10 >> + This is a minor fix by the way. > > I dont get this line? Better clear it up before landing. Thanks Rob, calling setAutofilled() on the input element will get it painted with yellow background which can notify user this input is auto filled by browser. I forget to add this in the former patches. will explain this in changelog with my next patch.
Jonathan Dong
Comment 4 2012-05-04 07:56:13 PDT
Created attachment 140225 [details] Patch
Rob Buis
Comment 5 2012-05-04 08:07:12 PDT
Comment on attachment 140225 [details] Patch Looks good, I hope Leo, Charles or Mary can help with landing.
Jonathan Dong
Comment 6 2012-05-06 03:27:46 PDT
hi Rob, do you know what's wrong with it? Charles has helped on cq+ this patch in the early morning this Saturday, but it hasn't get landed yet until now, and there's no status update. Do I need to re-submit it? and we are not able to see the build status here in china, :(
Rob Buis
Comment 7 2012-05-06 09:23:42 PDT
Hi Jonathan, (In reply to comment #6) > hi Rob, do you know what's wrong with it? Charles has helped on cq+ this patch in the early morning this Saturday, but it hasn't get landed yet until now, and there's no status update. Do I need to re-submit it? > > and we are not able to see the build status here in china, :( Maybe the queue is stuck, I'll keep an eye on it.
WebKit Review Bot
Comment 8 2012-05-06 15:04:54 PDT
Comment on attachment 140225 [details] Patch Clearing flags on attachment: 140225 Committed r116241: <http://trac.webkit.org/changeset/116241>
WebKit Review Bot
Comment 9 2012-05-06 15:05:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.