Bug 85571 – Convert setDefersLoading to use InternalSettings interface

• Status: RESOLVED
• Resolution: INVALID
• Component: Tools / Tests

[Gyuyoung Kim]

Adjust setDefersLoading tests to use InternalSettings instead of LayoutTestController interface. In my opinion, setDeferLoading() is able to be supported by InternalSettings because this feature just enables/disables defer loading feature in page settings. In addition, this feature is implemented by DumpRenderTreeSupportXXX of ports instead of public APIs.


For example, in Qt port case,

void LayoutTestController::setDefersLoading(bool flag)
{
    DumpRenderTreeSupportQt::setDefersLoading(m_drt->webPage(), flag);
}


void DumpRenderTreeSupportQt::setDefersLoading(QWebPage* page, bool flag)
{
    Page* corePage = QWebPagePrivate::core(page);
    if (corePage)
        corePage->setDefersLoading(flag);
}

Hello  Alexey, I would like to know how do you think about this ?

[Gyuyoung Kim]

I'm sorry. This feature can't be moved to Internals. Because QT and EFL port sets this option as false via DumpRenderTreeSupportXXX's funtion when starting a test case. So, DumpRenderTreeSupportXXX needs to be kept.