Bug 85537 - Histogram total allocated bytes in the arena in addition to the render tree size
Summary: Histogram total allocated bytes in the arena in addition to the render tree size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks: 87967
  Show dependency treegraph
 
Reported: 2012-05-03 13:06 PDT by Ojan Vafai
Modified: 2012-05-31 06:24 PDT (History)
3 users (show)

See Also:


Attachments
Patch (8.68 KB, patch)
2012-05-03 13:10 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (8.86 KB, patch)
2012-05-03 15:22 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (8.82 KB, patch)
2012-05-03 16:08 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-05-03 13:06:26 PDT
Histogram total allocated bytes in the arena in addition to the render tree size
Comment 1 Ojan Vafai 2012-05-03 13:10:04 PDT
Created attachment 140078 [details]
Patch
Comment 2 Ojan Vafai 2012-05-03 13:12:25 PDT
I'm a bit torn on making the bytesAllocated an out-param instead of just adding a new method to Page. It avoids some code duplication. In theory it's also faster because we only walk the frame-tree once, but I doubt that matters in practice.

Happy to change it if you think a separate method would be cleaner.
Comment 3 Eric Seidel (no email) 2012-05-03 13:19:53 PDT
Comment on attachment 140078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140078&action=review

> Source/WebCore/page/Page.h:121
> -        size_t renderTreeSize() const;
> +        size_t renderTreeSize(size_t& totalRenderArenaAllocatedBytes) const;

You could alternatively return a simple struct?
Comment 4 Ojan Vafai 2012-05-03 13:23:00 PDT
(In reply to comment #3)
> (From update of attachment 140078 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140078&action=review
> 
> > Source/WebCore/page/Page.h:121
> > -        size_t renderTreeSize() const;
> > +        size_t renderTreeSize(size_t& totalRenderArenaAllocatedBytes) const;
> 
> You could alternatively return a simple struct?

That's probably cleaner. Will fix.
Comment 5 Build Bot 2012-05-03 13:42:22 PDT
Comment on attachment 140078 [details]
Patch

Attachment 140078 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12611316
Comment 6 Ojan Vafai 2012-05-03 15:22:18 PDT
Created attachment 140109 [details]
Patch
Comment 7 Build Bot 2012-05-03 15:47:36 PDT
Comment on attachment 140109 [details]
Patch

Attachment 140109 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12620250
Comment 8 Build Bot 2012-05-03 15:50:27 PDT
Comment on attachment 140109 [details]
Patch

Attachment 140109 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12612399
Comment 9 Early Warning System Bot 2012-05-03 16:03:18 PDT
Comment on attachment 140109 [details]
Patch

Attachment 140109 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12514238
Comment 10 Ojan Vafai 2012-05-03 16:08:20 PDT
Created attachment 140118 [details]
Patch
Comment 11 Ojan Vafai 2012-05-03 16:41:56 PDT
OK. All the bots are happily compiling now. Eric, squeak!
Comment 12 Eric Seidel (no email) 2012-05-03 17:10:01 PDT
Comment on attachment 140118 [details]
Patch

Works for me.
Comment 13 WebKit Review Bot 2012-05-03 18:34:58 PDT
Comment on attachment 140118 [details]
Patch

Clearing flags on attachment: 140118

Committed r116058: <http://trac.webkit.org/changeset/116058>
Comment 14 WebKit Review Bot 2012-05-03 18:35:04 PDT
All reviewed patches have been landed.  Closing bug.