Bug 85537 – Histogram total allocated bytes in the arena in addition to the render tree size

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

Histogram total allocated bytes in the arena in addition to the render tree size

[Ojan Vafai]

Created attachment 140078 [details]
Patch

[Ojan Vafai]

I'm a bit torn on making the bytesAllocated an out-param instead of just adding a new method to Page. It avoids some code duplication. In theory it's also faster because we only walk the frame-tree once, but I doubt that matters in practice.

Happy to change it if you think a separate method would be cleaner.

[Eric Seidel (no email)]

Comment on attachment 140078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140078&action=review

> Source/WebCore/page/Page.h:121
> -        size_t renderTreeSize() const;
> +        size_t renderTreeSize(size_t& totalRenderArenaAllocatedBytes) const;

You could alternatively return a simple struct?

[Ojan Vafai]

(In reply to comment #3)
> (From update of attachment 140078 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140078&action=review
> 
> > Source/WebCore/page/Page.h:121
> > -        size_t renderTreeSize() const;
> > +        size_t renderTreeSize(size_t& totalRenderArenaAllocatedBytes) const;
> 
> You could alternatively return a simple struct?

That's probably cleaner. Will fix.

[Build Bot]

Comment on attachment 140078 [details]
Patch

Attachment 140078 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12611316

[Ojan Vafai]

Created attachment 140109 [details]
Patch

[Build Bot]

Comment on attachment 140109 [details]
Patch

Attachment 140109 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12620250

[Build Bot]

Comment on attachment 140109 [details]
Patch

Attachment 140109 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12612399

[Early Warning System Bot]

Comment on attachment 140109 [details]
Patch

Attachment 140109 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12514238

[Ojan Vafai]

Created attachment 140118 [details]
Patch

[Ojan Vafai]

OK. All the bots are happily compiling now. Eric, squeak!

[Eric Seidel (no email)]

Comment on attachment 140118 [details]
Patch

Works for me.

[WebKit Review Bot]

Comment on attachment 140118 [details]
Patch

Clearing flags on attachment: 140118

Committed r116058: <http://trac.webkit.org/changeset/116058>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.