Bug 85535 - Remove dead code from build-webkit for working around old XCode dependency bug
Summary: Remove dead code from build-webkit for working around old XCode dependency bug
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on: 85597
Blocks: 85456
  Show dependency tree / graph
 
Reported: 2012-05-03 13:04 PDT by Eric Seidel (no email)
Modified: 2012-05-04 03:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.77 KB, patch)
2012-05-03 13:06 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-05-03 13:04:51 PDT 
Remove dead code from build-webkit for working around old XCode dependency bug
Comment 1 Eric Seidel (no email) 2012-05-03 13:06:52 PDT 
Created attachment 140076 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-03 13:07:15 PDT 
Comment on attachment 140076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140076&action=review

> Tools/Scripts/build-webkit:-426
> -$blobSupport = $blobSupport || $mediaStreamSupport;

I removed this line as I noticed it also was dead code. :)
Comment 3 Eric Seidel (no email) 2012-05-03 13:08:54 PDT 
I noticed this because I was am looking at autogenerating the feature defaults in build-webkit.  There are basically no uses of the local variables the default options map to, and these were 2 uses.  This code is dead, so we should just kill it. :)
Comment 4 WebKit Review Bot 2012-05-03 14:06:35 PDT 
Comment on attachment 140076 [details]
Patch

Clearing flags on attachment: 140076

Committed r116008: <http://trac.webkit.org/changeset/116008>
Comment 5 WebKit Review Bot 2012-05-03 14:06:41 PDT 
All reviewed patches have been landed.  Closing bug.