WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
85521
Remove non-overlap testing code in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=85521
Summary
Remove non-overlap testing code in RenderLayerCompositor
Simon Fraser (smfr)
Reported
2012-05-03 11:34:51 PDT
Overlap testing is now always active in RenderLayerCompositor. We should remove code related to the non-overlap path. I think this also eliminates the 'partial updates' notion in RenderLayerCompositor::updateCompositingLayers().
Attachments
Patch
(8.62 KB, patch)
2013-04-18 23:05 PDT
,
Shawn Singh
no flags
Details
Formatted Diff
Diff
Patch for landing
(8.92 KB, patch)
2013-04-19 13:11 PDT
,
Shawn Singh
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Shawn Singh
Comment 1
2013-04-18 23:05:42 PDT
Created
attachment 198806
[details]
Patch
Simon Fraser (smfr)
Comment 2
2013-04-19 08:59:17 PDT
Comment on
attachment 198806
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=198806&action=review
I would like to be able to reintroduce partial updates at some point, but OK.
> Source/WebCore/rendering/RenderLayerCompositor.cpp:547 > + CompositingState compState(updateRoot, true);
Mysterious 'true'. Can that be a parameter default value?
Shawn Singh
Comment 3
2013-04-19 13:11:26 PDT
Created
attachment 198911
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2013-04-19 13:40:12 PDT
Comment on
attachment 198911
[details]
Patch for landing Clearing flags on attachment: 198911 Committed
r148765
: <
http://trac.webkit.org/changeset/148765
>
WebKit Commit Bot
Comment 5
2013-04-19 13:40:16 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug