Bug 85509 – Add htmlSource() in PagePopupClient

• Status: UNCONFIRMED
• Component: WebCore Misc.

[Crystal Zhang]

For different kind of popup client, it needs to load different html source.

[Crystal Zhang]

Created attachment 140040 [details]
patch

patch

[WebKit Review Bot]

Comment on attachment 140040 [details]
patch

Attachment 140040 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12620160

[Crystal Zhang]

Created attachment 140044 [details]
updated patch, fix buid bug.

[Alexey Proskuryakov]

>     // This is called when load the content HTML

Is this the best description? It's unclear how this is supposed to be used, and in particular limiting to HTML seems surprising (where will CSS go?)

[Crystal Zhang]

The htmlsource string is the final sour(In reply to comment #4)
> >     // This is called when load the content HTML
> 
> Is this the best description? It's unclear how this is supposed to be used, and in particular limiting to HTML seems surprising (where will CSS go?)

The html source string is the final string that generated after include/load all the css, js files. It represents the whole HTML page.

[Kent Tamura]

Comment on attachment 140044 [details]
updated patch, fix buid bug.

View in context: https://bugs.webkit.org/attachment.cgi?id=140044&action=review

> Source/WebCore/page/PagePopupClient.h:63
> +    // This is called when load the content HTML
> +    virtual String htmlSource() { return String(); }

Why do we need this though we already have writeDocument(DocumentWriter&)?
Which should a PagePopupClient implementation provide? Which should a PagePopup implementation call?

ChangeLog should have such information.