Bug 85504 – webkitpy: Style checker broken when committing a PNG

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Thiago Marcos P. Santos]

$ ./Tools/Scripts/check-webkit-style -g HEAD
Traceback (most recent call last):
  File "./Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/main.py", line 154, in main
    patch_checker.check(patch)
  File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check
    self._text_file_reader.process_file(file_path=path, line_numbers=None)
  File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file
    self._processor.process(lines, file_path, **kwargs)
  File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checker.py", line 844, in process
    min_confidence)
  File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checker.py", line 619, in dispatch
    min_confidence)
  File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checker.py", line 593, in _create_checker
    checker = PNGChecker(file_path, handle_style_error)
  File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checkers/png.py", line 43, in __init__
    self._fs = host.filesystem
AttributeError: 'NoneType' object has no attribute 'filesystem'

[Thiago Marcos P. Santos]

Created attachment 140026 [details]
Patch

[Dirk Pranke]

Comment on attachment 140026 [details]
Patch

thanks for looking at this, but I'm pretty sure that would assign self._fs to host if host is non-null. Just change host to self._host on line 43.

[Thiago Marcos P. Santos]

(In reply to comment #2)
> (From update of attachment 140026 [details])
> thanks for looking at this, but I'm pretty sure that would assign self._fs to host if host is non-null. Just change host to self._host on line 43.

Yeah, I noticed that when running the utests here.

[Thiago Marcos P. Santos]

Created attachment 140032 [details]
patch

Fixes previous patch

[Dirk Pranke]

Comment on attachment 140032 [details]
patch

thanks!

[WebKit Review Bot]

Comment on attachment 140032 [details]
patch

Clearing flags on attachment: 140032

Committed r115986: <http://trac.webkit.org/changeset/115986>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.