Created attachment 140003 [details] Current buggy rendering result Button is not square enough, it has rounded corners.
Created attachment 162667 [details] Patch
Comment on attachment 162667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162667&action=review > Source/WebCore/ChangeLog:14 > + called from RenderThemeEfl::adjustButtonStyle add padding values for a button. add -> adds or added > Source/WebCore/ChangeLog:17 > + Unneeded line. > Source/WebCore/platform/efl/RenderThemeEfl.cpp:880 > + I think it is better to add short comment to here.
KyungTae, could you ask Thiago if you can submit a patch ?
Comment on attachment 162667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162667&action=review > Source/WebCore/ChangeLog:16 > + So, the adjustSizeConstraints must not be called for a sqaure-button(SquareButtonPart). "sqaure" -> "square"
I modified the typos. Sorry for the typos. Thiago said it's OK. He assigns this bug to me.
Created attachment 162688 [details] Patch
Comment on attachment 162688 [details] Patch Looks fine.
Comment on attachment 162688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162688&action=review > Source/WebCore/platform/efl/RenderThemeEfl.cpp:-881 > - adjustSizeConstraints(style, Button); I still think a comment will be help to understand why this code is added.
Created attachment 163023 [details] Patch
Comment on attachment 163023 [details] Patch Clearing flags on attachment: 163023 Committed r128013: <http://trac.webkit.org/changeset/128013>
All reviewed patches have been landed. Closing bug.