Bug 85479 - [EFL] Handling of numeric-pad keys in EFL's PlatformKeyboardEvent
Summary: [EFL] Handling of numeric-pad keys in EFL's PlatformKeyboardEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 85369
  Show dependency tree / graph
 
Reported: 2012-05-03 05:20 PDT by Mikhail Pozdnyakov
Modified: 2012-05-22 11:14 PDT (History)
4 users (show)

See Also:

Attachments
Handling of numeric-pad keys in EFL's PlatformKeyboardEvent (4.67 KB, patch)
2012-05-03 05:43 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-05-03 05:20:52 PDT 
EFL's PlatformKeyboardEvent::isKeypad() should be implemented and codes for numeric-pad ("KP..") keys should be returned appropriately
in order to unskip:
fast/events/keydown-numpad-keys.html
Comment 1 Mikhail Pozdnyakov 2012-05-03 05:43:56 PDT 
Created attachment 139994 [details]
Handling of numeric-pad keys in EFL's PlatformKeyboardEvent
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-03 08:11:19 PDT 
Comment on attachment 139994 [details]
Handling of numeric-pad keys in EFL's PlatformKeyboardEvent

Looks OK.
Comment 3 Gustavo Noronha (kov) 2012-05-08 13:07:12 PDT 
Comment on attachment 139994 [details]
Handling of numeric-pad keys in EFL's PlatformKeyboardEvent

OK. Now just the numpad keys missing? =)
Comment 4 WebKit Review Bot 2012-05-08 13:24:07 PDT 
Comment on attachment 139994 [details]
Handling of numeric-pad keys in EFL's PlatformKeyboardEvent

Clearing flags on attachment: 139994

Committed r116452: <http://trac.webkit.org/changeset/116452>
Comment 5 WebKit Review Bot 2012-05-08 13:24:12 PDT 
All reviewed patches have been landed.  Closing bug.